-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable9] Fix LDAP race conditions #24242
Conversation
* getFromCache is wrapped in isCached * inbetween the two calls the cache entry hits it's TTL * getFromCache returns null * this fix only checkes if the returned value is null and return only non-null values
cc @blizzz @nickvergessen @LukasReschke @davitol @owncloud/qa @owncloud/ldap We need some LDAP testing here. |
The login fails for an AD server:
|
Stack trace:
|
Maybe it's caused by a somehow wrongly setup AD? cc @davitol |
AD login works for me |
The backtrace is file/storage related. Maybe some remnants from another test case? |
Looks good and works for me 👍 |
It was a fresh installation for this test.
Same AD configuration in another server without the patch let me to log in with my AD user. Let me test this patch again and i`ll tell you the results |
And hand over the credentials for this machine. Then I will try to bisect this. |
@MorrisJobke @blizzz I have reboot the machine of the AD server, and now it works perfect with the patch too. 👍 |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
return only non-null values