triger the propagator from the command line scanner #24256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @LukasReschke, @DeepDiver1975 and @nickvergessen to be potential reviewers |
| @@ -168,5 +180,9 @@ public function scan($dir = '') { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| private function triggerPropagator(IStorage $storage, $internalPath) { | |||
| $storage->getPropagator()->propagateChange($internalPath, time()); | |||
There was a problem hiding this comment.
@icewind1991 can you remind me whether this is debounced on the path ?
Because if we detect several changes within the same folder, it would be expensive to propagate the etag to the parents several times for every found file.
|
Tested, works 👍 @karlitschek backport to 9.0.2 ? |
|
great. please backport |
|
@icewind1991 please submit the backport PR, thanks |
|
stable9: #24261 |
|
👍 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24255
cc @PVince81