New animated loader: full css

[skjnldsv]

New spinner. This time we're going full css. This is the best solution.
See discussion in ref issue.

We have a gif fall-back for css replaced elements (inputs, img...). This should easily do the trick, and is fully compatible with all browsers (including IE \o/)
I also added a small black loading icon: icon-loading-small-dark

ref and fix #19091
@oparoz @Henni @jancborchardt @PVince81

[skjnldsv]

Seems to have an issue with some of the gifs. I'm checking it.

[skjnldsv]

Ok, fixed now! :)
Gifs are now optimised and a bit more visible. Obviously, the render isn't as good as the full css, but this is a fallback after all ;)

[MorrisJobke]

Ready for reviews?

[skjnldsv]

@MorrisJobke
Yes! :)

[ChristophWurst]

When opening a text file with the text editor, the loading spinner stays forever. Does not happen with the old spinner on master.
Apart from that it looks very nice! Tested with FF on Linux

[skjnldsv]

See owncloud/files_texteditor#173 for the text loading bug.
Not related to this commit:

<skjnldsv> ok I think I see why
<skjnldsv> the class stays
<skjnldsv> but the textarea just go over it
<skjnldsv> so the loading is not visible
<skjnldsv> but now, because we're not using a background but a separated css element (::after) its stays on top
<ChristophWurst> ah, so it's just a coincidence it worked with the old one? :D
<skjnldsv> exactly ^^

[ChristophWurst]

👍 then, no other problems detected

[MorrisJobke]

Tested, looks really nice and works also in IE11 👍 😃

[MorrisJobke]

@DeepDiver1975 JSUnit tests pass and the other stuff is CSS only. Could you merge this?

[skjnldsv]

Finally! \o/

[jancborchardt]

Nice dude, great work! :)

[skjnldsv]

Thanks @jancborchardt !
Took a while to figure out the best.

[oparoz]

Well done @skjnldsv - This was merged rather quickly, so let's hope enough people will be able to test it before launch to offer feedback. I still think the ring is a bit thin which makes it too discreet in some situations. We'll see :)

[skjnldsv]

We already review the colors previously with jan!
I think this is alright (except the gif), we'll see if something comes up :)

[jancborchardt]

Yeah, now we have enough time to see it in action so it's good we finally merged it! :)

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.