-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use array_merge when reading cached groups members #25024
Conversation
By analyzing the blame information on this pull request, we identified @blizzz, @leo-b and @alexweirig to be potential reviewers |
Can't test, but looks way better logicwise to me 👍 |
👍 |
unit tests? |
😢 I can have a try but it might take a day or two, especially considering that there is no test for this section of the code. |
Let's see whether I can mock my way into that specific branch of the code... that function is huge! |
Ha, take this! 059778b Reverting the array_merge change will make this fail. Please review! |
@PVince81 |
@alexweirig thanks a lot! |
Backports are pending - down to which version?
|
Sorry, forgot to remove the label. This was a special case: we already had a backport to 9.0 #24950 (comment) but @nickvergessen found a problem. This PR here fixes it and I cherry-picked the fix to the backport PR, which is also merged already. |
@DeepDiver1975 maybe backport to 8.2 if possible? |
Not needed, because the breaking commit was only introduced with 9.0+ |
But 8.2 didn't even have dynamic groups support, we implemented it based on 8.2 and we're still using 8.2.1 because later 8.2 versions don't have it, or am I wrong? |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
For #24950 (comment)
@nickvergessen @alexweirig @owncloud/ldap