Ignore invalid paths in the JS file list #25368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 looks good |
|
works 👍 |
|
preparing backports |
DeepDiver1975
pushed a commit
that referenced
this pull request
Jul 6, 2016
DeepDiver1975
pushed a commit
that referenced
this pull request
Jul 6, 2016
This was referenced Jul 6, 2016
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review @ChristophWurst @guruz @georgehrke @VicDeo @DeepDiver1975
You can test this by adding ".." sections in the URL directly, for example:
http://localhost/owncloud/index.php/apps/files/?dir=/../../something
Note that on master you'll have to remove the fileid argument as it takes precedence over the path.
Should be backported to stable9.1 and stable9.