getJailedPath expects $path to have a trailing / #25703
Conversation
|
|
|
@DeepDiver1975, thanks for your PR! By analyzing the annotation information on this pull request, we identified @icewind1991, @rullzer and @PVince81 to be potential reviewers |
|
Tested on 9.0.4. Works THX! |
DeepDiver1975
force-pushed
the
fix-sharing-tagging-comments-on-mounted-subfolders-master
branch
from
5313a71 to
d817484
Compare
|
@pako81 mind retesting? I had to change the fix in order to avoid regressions in other areas 😵 |
|
@DeepDiver1975 👍 yes, seems to work for already existing files/folders as well as for newly-created ones. |
| @@ -58,6 +58,9 @@ protected function getSourcePath($path) { | |||
| * @return null|string the jailed path or null if the path is outside the jail | |||
| */ | |||
| protected function getJailedPath($path) { | |||
| if ($this->root === '') { | |||
| return $path; | |||
There was a problem hiding this comment.
@DeepDiver1975 Mind explaining how this fix fits in with the PR description ? (no reference to slashes here)
Maybe add a comment in the code to clarify for future reference.
There was a problem hiding this comment.
The shared storage is a jailed storage and usually in case of sharing the jailed storage is some folder down somewhere in the users folders structure.
Not in case of sharing a mounted external storage - then the mount point itself is shared and it is the root of the mount which gets jailed.
|
Makes sense 👍 |
DeepDiver1975
deleted the
fix-sharing-tagging-comments-on-mounted-subfolders-master
branch
* getJailedPath expects $path to have a trailing / - fixes #25464 * Adding test case for getPathById including a jailed cache where root is just empty
|
stable9.1: #25737 |
* getJailedPath expects $path to have a trailing / - fixes #25464 * Adding test case for getPathById including a jailed cache where root is just empty
|
stable9: #25738 |
…f68d48fe05f290127db7e [stable9.1] getJailedPath expects $path to have a trailing / (#25703)
* getJailedPath expects $path to have a trailing / - fixes #25464 * Adding test case for getPathById including a jailed cache where root is just empty
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
fixes #25464