[stable9.1] Repair oc_mounts' shared:: storages that must not be #25804
Conversation
|
@PVince81, thanks for your PR! By analyzing the annotation information on this pull request, we identified @DeepDiver1975, @nickvergessen and @LukasReschke to be potential reviewers |
|
|
This repair step would also repair cases like #25805 where the storage id doesn't match. |
|
Code looks good 👍 |
Delete oc_mounts' shared:: storages entries because they refer to a bogus storage entries. These entries will be recreated with the correct format the next time the user logs in.
DeepDiver1975
force-pushed
the
stable9.1-repair-ocmounts-shared
branch
from
ba231b0
to
856d391
Compare
|
To delete the bogus shared:: storages: delete all oc_storages entries where the storage id starts with "shared::/" (with slash + file target). These entries should never have existed before so should be safe to delete (to double check!). Unfortunately there might be cases where the whole storage id is a md5 if the file target was too long... deleting these would need iterating over all users and is expensive, but also a rare case, so can maybe be ignored for now... |
| } | ||
|
|
||
| private function repairMountEntries(IOutput $output) { | ||
| $pageSize = self::CHUNK_SIZE; |
There was a problem hiding this comment.
What if the number of results is greater than the chunk size?
There was a problem hiding this comment.
Argh, you're right. It seems I forgot adding a setOffset() before reexecuting.
|
no time for time, also not really critical |
|
pffff, not sure if this is really worth it. One can just clear |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
For #24106
Delete oc_mounts' shared:: storages entries because they refer to a bogus storage entries. These entries will be recreated with the correct format the next time the user logs in.
This situation is only created in OC 9.0. New entries are created properly since 9.1 so this repair step is only to make the entries properly consistent.
Please review @owncloud/filesystem @owncloud/sharing @VicDeo @jvillafanez @butonic