Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't log credentials of LoginController::tryLogin #25902

Merged
merged 2 commits into from
Aug 24, 2016
Merged

Conversation

DeepDiver1975
Copy link
Member

fixes #25895

@mention-bot
Copy link

@DeepDiver1975, thanks for your PR! By analyzing the annotation information on this pull request, we identified @MorrisJobke, @bartv2 and @nickvergessen to be potential reviewers

@PVince81
Copy link
Contributor

👍

@PVince81
Copy link
Contributor

MEEP

17:19:45 1) Test\LoggerTest::testDetecttryLogin with data set #0 ('abc', 'def')
17:19:45 Failed asserting that '3 Exception: {"Exception":"Exception","Message":"test","Code":0,"Trace":"#0 [internal function]: Test\\LoggerTest->testDetecttryLogin(*** sensitive parameters replaced ***)\n#1 phar:\/\/\/usr\/local\/bin\/phpunit\/phpunit\/Framework\/TestCase.php(908): ReflectionMethod->invokeArgs(Object(Test\\LoggerTest), Array)\n#2 phar:\/\/\/usr\/local\/bin\/phpunit\/phpunit\/Framework\/TestCase.php(768): PHPUnit_Framework_TestCase->runTest()\n#3 phar:\/\/\/usr\/local\/bin\/phpunit\/phpunit\/Framework\/TestResult.php(612): PHPUnit_Framework_TestCase->runBare()\n#4 phar:\/\/\/usr\/local\/bin\/phpunit\/phpunit\/Framework\/TestCase.php(724): PHPUnit_Framework_TestResult->run(Object(Test\\LoggerTest))\n#5 phar:\/\/\/usr\/local\/bin\/phpunit\/phpunit\/Framework\/TestSuite.php(747): PHPUnit_Framework_TestCase->run(Object(PHPUnit_Framework_TestResult))\n#6 phar:\/\/\/usr\/local\/bin\/phpunit\/phpunit\/Framework\/TestSuite.php(747): PHPUnit_Framework_TestSuite->run(Object(PHPUnit_Framework_TestResult))\n#7 phar:\/\/\/usr\/local\/bin\/phpunit\/phpunit\/Framework\/TestSuite.php(747): PHPUnit_Framework_TestSuite->run(Object(PHPUnit_Framework_TestResult))\n#8 phar:\/\/\/usr\/local\/bin\/phpunit\/phpunit\/TextUI\/TestRunner.php(440): PHPUnit_Framework_TestSuite->run(Object(PHPUnit_Framework_TestResult))\n#9 phar:\/\/\/usr\/local\/bin\/phpunit\/phpunit\/TextUI\/Command.php(149): PHPUnit_TextUI_TestRunner->doRun(Object(PHPUnit_Framework_TestSuite), Array)\n#10 phar:\/\/\/usr\/local\/bin\/phpunit\/phpunit\/TextUI\/Command.php(100): PHPUnit_TextUI_Command->run(Array, true)\n#11 \/usr\/local\/bin\/phpunit(548): PHPUnit_TextUI_Command::main()\n#12 {main}","File":"\/var\/lib\/jenkins\/workspace\/owncloud-core\/core\/PR-25902\/tests\/lib\/LoggerTest.php","Line":133}' contains "validateUserPass(*** sensitive parameters replaced ***)".
17:19:45 
17:19:45 /var/lib/jenkins/workspace/owncloud-core/core/PR-25902/tests/lib/LoggerTest.php:140

@DeepDiver1975

@DeepDiver1975
Copy link
Member Author

MEEP

nooo432

@DeepDiver1975
Copy link
Member Author

@kostas707 THX a lot - mind testing again?

@PVince81
Copy link
Contributor

👍

@PVince81 PVince81 merged commit c1aa090 into master Aug 24, 2016
@PVince81 PVince81 deleted the fix-25895-master branch August 24, 2016 07:19
@PVince81
Copy link
Contributor

@DeepDiver1975 please backport

@kostas707
Copy link

Thomas, Vincent, viel Danke. Thanks, now all fine. Have a nice days guys 👍

DeepDiver1975 added a commit that referenced this pull request Aug 24, 2016
* Don't log credentials of LoginController::tryLogin - fixes #25895

* Don't log password in loginWithPassword
DeepDiver1975 added a commit that referenced this pull request Aug 29, 2016
… (#25935)

* Don't log credentials of LoginController::tryLogin - fixes #25895

* Don't log password in loginWithPassword
@lock
Copy link

lock bot commented Aug 4, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After upgrade from 8.2 to 9.1: plain password in owncloud.log
4 participants