Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update composer.lock for updated libs #26476

Merged
merged 1 commit into from
Oct 28, 2016
Merged

Update composer.lock for updated libs #26476

merged 1 commit into from
Oct 28, 2016

Conversation

PVince81
Copy link
Contributor

To fix the warning that composer.lock is not up to date.

This PR updates composer.lock through make update-composer.

@DeepDiver1975 @PhilippSchaffrath please double check to be sure this update is correct.

@PVince81 PVince81 added this to the 9.2 milestone Oct 25, 2016
@mention-bot
Copy link

@PVince81, thanks for your PR! By analyzing the history of the files in this pull request, we identified @DeepDiver1975 to be a potential reviewer.

@phisch
Copy link
Contributor

phisch commented Oct 25, 2016

That's exactly what i expected. I had the same strange errors in the tests when i updated the dependencies last time. Good to have a separate ticket for that now :)

1) Test\App\ManagerTest::testEnableApp
ParseError: syntax error, unexpected '??' (T_COALESCE), expecting variable (T_VARIABLE)
...

I have no clue what is going on there!

@PVince81
Copy link
Contributor Author

Doesn't happen for me locally with PHP 5.6.27.

@PVince81
Copy link
Contributor Author

Sometimes Jenkins is sick... pushing a separate branch to verify: #26479

@phisch
Copy link
Contributor

phisch commented Oct 25, 2016

Same happened again, just like when i pushed a composer update.

@PVince81
Copy link
Contributor Author

runtime: PHP 7.1.0RC1

let's try that locally...

@PVince81
Copy link
Contributor Author

Ok, locally I also get this with 7.1.0RC1 (from phpenv):

1) Test\App\ManagerTest::testEnableApp
ParseError: syntax error, unexpected '??' (T_COALESCE), expecting variable (T_VARIABLE)

Let's try again with 7.1.0RC4.

@PVince81
Copy link
Contributor Author

No such weird issues with 7.1.0RC4.

@DeepDiver1975 can we update Jenkins from 7.1.0RC1 to 7.1.0RC4 ?

@phisch
Copy link
Contributor

phisch commented Oct 25, 2016

No such issues with 7.0.8 too.

@DeepDiver1975
Copy link
Member

7.1RC4 is now available on jenkins ...

@DeepDiver1975
Copy link
Member

aha - much better with 7.1RC4

0:23:26 Time: 1.42 minutes, Memory: 172.00MB
00:23:26 
00:23:26 There were 4 failures:
00:23:26 
00:23:26 1) Test\Comments\ManagerTest::testGetComment
00:23:26 Failed asserting that two DateTime objects are equal.
00:23:26 --- Expected
00:23:26 +++ Actual
00:23:26 @@ @@
00:23:26  2016-10-25T22:22:04+0000
00:23:26 
00:23:26 /var/lib/jenkins/workspace/owncloud-core_core_PR-26476-MNN7CDVM5JONKOMQNADXUNNP62OTCAGAR5OFYESKH4STOA3OS3EQ/tests/lib/Comments/ManagerTest.php:110
00:23:26 
00:23:26 2) Test\Comments\ManagerTest::testSaveNew
00:23:26 Failed asserting that two DateTime objects are equal.
00:23:26 --- Expected
00:23:26 +++ Actual
00:23:26 @@ @@
00:23:26  2016-10-25T22:22:04+0000
00:23:26 
00:23:26 /var/lib/jenkins/workspace/owncloud-core_core_PR-26476-MNN7CDVM5JONKOMQNADXUNNP62OTCAGAR5OFYESKH4STOA3OS3EQ/tests/lib/Comments/ManagerTest.php:372
00:23:26 
00:23:26 3) Test\Comments\ManagerTest::testSetMarkRead
00:23:26 Failed asserting that two DateTime objects are equal.
00:23:26 --- Expected
00:23:26 +++ Actual
00:23:26 @@ @@
00:23:26  2016-10-25T22:22:04+0000
00:23:26 
00:23:26 /var/lib/jenkins/workspace/owncloud-core_core_PR-26476-MNN7CDVM5JONKOMQNADXUNNP62OTCAGAR5OFYESKH4STOA3OS3EQ/tests/lib/Comments/ManagerTest.php:576
00:23:26 
00:23:26 4) Test\Share20\DefaultShareProviderTest::testCreateLinkShare
00:23:26 Failed asserting that two DateTime objects are equal.
00:23:26 --- Expected
00:23:26 +++ Actual
00:23:26 @@ @@
00:23:26  2016-10-25T22:22:22+0000
00:23:26 
00:23:26 /var/lib/jenkins/workspace/owncloud-core_core_PR-26476-MNN7CDVM5JONKOMQNADXUNNP62OTCAGAR5OFYESKH4STOA3OS3EQ/tests/lib/Share20/DefaultShareProviderTest.php:747
00:23:26 
00:23:26 --

@DeepDiver1975
Copy link
Member

Failed auch auf master

@PVince81
Copy link
Contributor Author

Let's merge this PR then and address the issues in a separate one since they aren't related to composer.lock ? @DeepDiver1975

@PVince81
Copy link
Contributor Author

Raised #26488 to fix test failures for 7.1.0RC4

@PVince81
Copy link
Contributor Author

Fix for the failures on master is here: #26502

@butonic
Copy link
Member

butonic commented Oct 28, 2016

👍

@PVince81 PVince81 force-pushed the update-composer-lock branch from bc64fe2 to 4e9f8a2 Compare October 28, 2016 08:29
@PVince81
Copy link
Contributor Author

rebased

@PVince81 PVince81 merged commit 2358af2 into master Oct 28, 2016
@PVince81 PVince81 deleted the update-composer-lock branch October 28, 2016 11:44
@lock
Copy link

lock bot commented Aug 4, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants