Display changes in file versions tab view and detailsView #26511
Conversation
|
|
|
@mjobst-necls, thanks for your PR! By analyzing the history of the files in this pull request, we identified @PVince81, @schiessle and @icewind1991 to be potential reviewers. |
|
Using Chrome Version 54.0.2840.71 (64-bit) in OSX PR applied: PR not applied: |
There was a problem hiding this comment.
Great PR, love it! Also works well.
There are a few minor issues, please see my review comments.
Would you mind adding the size field in the JS unit tests here https://github.com/owncloud/core/blob/v9.1.1/apps/files_versions/tests/js/versionstabviewSpec.js#L80 ?
| } | ||
|
|
||
| .versionsTabView .version-details > .size { | ||
| vertical-align: super; |
There was a problem hiding this comment.
Not sure why "super" here ?
On Chromium for me the size appears under the date but not as superscript. It does look good already, so not sure why. If you wanted to shift it up a bit you could try vertical-align: middle and set a different line-height.
| '<img class="preview" src="{{previewUrl}}"/>' + | ||
| '<a href="{{downloadUrl}}" class="downloadVersion"><img src="{{downloadIconUrl}}" />' + | ||
| '<span class="versiondate has-tooltip" title="{{formattedTimestamp}}">{{relativeTimestamp}}</span>' + | ||
| '<li data-revision="{{timestamp}}">' + |
There was a problem hiding this comment.
Please use tabs instead of spaces in all the changed lines.
By the way, since 9.2 OC only supports IE >= 11 so no need to test in much older versions 😄 |
|
BTW also tested in Safari Version 9.1.2 (10601.7.7) and Firefox 49.0.2 and it went fine |
It works but maybe ideally it would be great that the star will turn into yellow on mouse over as it happens in the files view. With this PR, the star keeps in grey. BTW it is a better behaviour than before. Great job!!
|
Can please someone tell me why chrome displays code different on OSX than on other OSs. Do you guys know a possibility how to test the code on OSX without apple hardware? I use a vm for tests on windows.
Thank you, I'm going to create another PR to cover your change requests regarding the color of the favorite star on hover and the JS unit test enhancements. |
|
@mjobst-necls a separate PR for the favorite star color is fine. However could you add the JS unit test extension to this PR to make it complete since this enhancement is mostly about the versions tab ? |
enhanced js test file removed css superscript attribute for version size
|
Ok, commit done. |
| return _.extend({ | ||
| formattedTimestamp: OC.Util.formatDate(timestamp), | ||
| relativeTimestamp: OC.Util.relativeModifiedDate(timestamp), | ||
| humanReadableSize: OC.Util.humanFileSize(size, true), | ||
| altSize: n('files', '%n byte', '%n bytes', size), | ||
| hasDetails: version.has('size'), |
There was a problem hiding this comment.
seems you missed some tabs here
There was a problem hiding this comment.
omg ^^. you're right ....
|
Thanks. Apart from the missed tabs this looks good. |
|
👍 merged, thanks a lot! Added to features page: https://github.com/owncloud/core/wiki/ownCloud-9.2-Features |
…6511) * Display changes in file versions tab view and detailsView * versions tab enhancements enhanced js test file removed css superscript attribute for version size * Replaced spaces with tabs
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
I made some changes to improve the file version tab.
Related Issue
Issue Tag: #26510
Motivation and Context
This pull requests contains code to view the version file size on the file version tab.
Another little change was done for the favourite "star" button on the details view. The opacity of this button changes to 1 on mouse over by this pull request.
How Has This Been Tested?
The test was ok for the following browsers:
Screenshots (if appropriate):
Types of changes
Checklist: