Add repair step to fix file share permissions

[PVince81]

Description

Related Issue

Fixes for #26541.

Motivation and Context

See issue

How Has This Been Tested?

Unit test.

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

Backports:

• stable9.1
• stable9

@jvillafanez

[mention-bot]

@PVince81, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nickvergessen, @DeepDiver1975 and @owncloud-bot to be potential reviewers.

[jvillafanez]

❗️
According to http://www.orafaq.com/wiki/Bit , Oracle doesn't support that operator. I'm not sure if this is somehow patched in the DB layer.

[PVince81]

Yeah, when writing this I wasn't sure but wanted to let it run on CI... CI will confirm.
If we don't have bitmask operations then it will be much more painful to implement.
I'm not happy to have to first gather all shares and then iterate over each and do the combination on PHP level.

[nickvergessen]

To fix postgres $builder->createFunction('(' . $builder->getColumnName('permissions') . ' & ' . $mask . ')')) should be enough.

But I guess to correctly fix this, you should add a new method to IExpressionBuilder. Then Oracle can haz it's own fucked up implementation.

[PVince81]

Thanks for the hints. Doing this inline for now, let's see if the tests pass...

[PVince81]

Hah, look... PostgreSQL failed first:

1) Test\Repair\RepairInvalidSharesTest::testRemoveExpirationDateForNonLinkShares
12:57:19 Doctrine\DBAL\Exception\DriverException: An exception occurred while executing 'UPDATE "oc_share" SET "permissions" = permissions & 19 WHERE ("item_type" = 'file') AND ("permissions" <> permissions & 19)':
12:57:19 
12:57:19 SQLSTATE[42883]: Undefined function: 7 ERROR:  operator does not exist: boolean & integer
12:57:19 LINE 1: ...item_type" = 'file') AND ("permissions" <> permissions & 19)
12:57:19                                                                   ^
12:57:19 HINT:  No operator matches the given name and argument type(s). You might need to add explicit type casts.
12:57:19 
12:57:19 /var/lib/jenkins/workspace/owncloud-core_core_PR-26562-37KEVOZ7VANINVKDU34LIJR7BDYJA5AB65ORYZHXL7OTWVZVE2DQ/lib/composer/doctrine/dbal/lib/Doctrine/DBAL/Driver/AbstractPostgreSQLDriver.php:91
12:57:19 /var/lib/jenkins/workspace/owncloud-core_core_PR-26562-37KEVOZ7VANINVKDU34LIJR7BDYJA5AB65ORYZHXL7OTWVZVE2DQ/lib/composer/doctrine/dbal/lib/Doctrine/DBAL/DBALException.php:128
12:57:19 /var/lib/jenkins/workspace/owncloud-core_core_PR-26562-37KEVOZ7VANINVKDU34LIJR7BDYJA5AB65ORYZHXL7OTWVZVE2DQ/lib/composer/doctrine/dbal/lib/Doctrine/DBAL/Connection.php:996
12:57:19 /var/lib/jenkins/workspace/owncloud-core_core_PR-26562-37KEVOZ7VANINVKDU34LIJR7BDYJA5AB65ORYZHXL7OTWVZVE2DQ/lib/private/DB/Connection.php:209
12:57:19 /var/lib/jenkins/workspace/owncloud-core_core_PR-26562-37KEVOZ7VANINVKDU34LIJR7BDYJA5AB65ORYZHXL7OTWVZVE2DQ/lib/composer/doctrine/dbal/lib/Doctrine/DBAL/Query/QueryBuilder.php:208
12:57:19 /var/lib/jenkins/workspace/owncloud-core_core_PR-26562-37KEVOZ7VANINVKDU34LIJR7BDYJA5AB65ORYZHXL7OTWVZVE2DQ/lib/private/DB/QueryBuilder/QueryBuilder.php:141
12:57:19 /var/lib/jenkins/workspace/owncloud-core_core_PR-26562-37KEVOZ7VANINVKDU34LIJR7BDYJA5AB65ORYZHXL7OTWVZVE2DQ/lib/private/Repair/RepairInvalidShares.php:105
12:57:19 /var/lib/jenkins/workspace/owncloud-core_core_PR-26562-37KEVOZ7VANINVKDU34LIJR7BDYJA5AB65ORYZHXL7OTWVZVE2DQ/lib/private/Repair/RepairInvalidShares.php:158
12:57:19 /var/lib/jenkins/workspace/owncloud-core_core_PR-26562-37KEVOZ7VANINVKDU34LIJR7BDYJA5AB65ORYZHXL7OTWVZVE2DQ/tests/lib/Repair/RepairInvalidSharesTest.php:108

[PVince81]

Looks like PostgreSQL will needs its own exception too: 😱

17:12:45 SQLSTATE[42883]: Undefined function: 7 ERROR:  operator does not exist: boolean & integer
17:12:45 LINE 1: ...em_type" = 'file') AND ("permissions" <> "permissions" & 19)

[nickvergessen]

(Need (more (brackets)))

[PVince81]

Added cast(XYZ as int) as per https://www.postgresql.org/docs/9.4/static/functions-bitstring.html.
Seems to work for sqlite and mysql as well.

Let's see...

[nickvergessen]

As commented before '(' . $builder->getColumnName('permissions') . ' & ' . $mask . ')' is what you need...

[PVince81]

I wanted to wait for another test run. Oh well, it failed again.
Will try with extra safety brackets.

[PVince81]

The magic has worked !

Now rebased+squashed.

[PVince81]

@jvillafanez review ?

[jvillafanez]

👍

[PVince81]

stable9.1: #26617
stable9: #26618

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.