On the login screen a warning will pop up if an unsupported/outdated browser is used #26967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DeepDiver1975, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bartv2, @vincchan and @butonic to be potential reviewers. |
PVince81
reviewed
Jan 18, 2017
| @@ -1,10 +1,12 @@ | |||
| <?php /** @var $l \OCP\IL10N */ ?> | |||
| <?php | |||
| vendor_script('jsTimezoneDetect/jstz'); | |||
| //vendor_script('browser-update/browser-update'); | |||
| @@ -91,4 +93,4 @@ | |||
| </ul> | |||
| </fieldset> | |||
| </form> | |||
| <?php } | |||
| <?php } ?> | |||
There was a problem hiding this comment.
Hmm, I thought we usually never close the php block at the end of files
pmaier1
approved these changes
Jan 18, 2017
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We should notify the user if an outdated browser is used
Motivation and Context
Screenshots (if appropriate):
Types of changes
Checklist: