Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill OC_Group #27341

Merged
merged 1 commit into from
Mar 9, 2017
Merged

Kill OC_Group #27341

merged 1 commit into from
Mar 9, 2017

Conversation

DeepDiver1975
Copy link
Member

Description

Finally it's about time to get rid of the legacy class OC_Group.
This class is also causing trouble with #27276

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@DeepDiver1975 DeepDiver1975 added this to the 10.0 milestone Mar 8, 2017
@mention-bot
Copy link

@DeepDiver1975, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bartv2, @fmms and @houqp to be potential reviewers.

@PVince81
Copy link
Contributor

PVince81 commented Mar 8, 2017

Some apps in https://github.com/owncloud/apps seem to use OC_Group to register their group backends and other things. Let's raise a ticket there after this is merged.

@PVince81
Copy link
Contributor

PVince81 commented Mar 8, 2017

raised LDAP ticket: owncloud/user_ldap#61

@PVince81
Copy link
Contributor

PVince81 commented Mar 8, 2017

raised ticket for apps: owncloud-archive/apps#2212

@DeepDiver1975
Copy link
Member Author

Some apps in https://github.com/owncloud/apps seem to use OC_Group to register their group backends and other things. Let's raise a ticket there after this is merged.

we for sure have to fix this .... THX for raising the issues

@PVince81
Copy link
Contributor

PVince81 commented Mar 9, 2017

👍

@PVince81 PVince81 merged commit 4653d69 into master Mar 9, 2017
@PVince81 PVince81 deleted the kill-OC_Group branch March 9, 2017 10:06
@lock
Copy link

lock bot commented Aug 3, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants