Use X-Request-ID header as request id if provided by client #28144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @jturcotte regarding the X-Request-ID header |
butonic
changed the title
butonic
changed the title
|
I added a few more chars to allow writing timestamps. But I don't want to allow Also ... while HEROKU just replaces invalid request IDs I want to fail early and hard ... which is why I throw the exception. Opinions? |
|
@butonic please fix le tests
|
|
@DeepDiver1975 I fixed le tests |
butonic
changed the title
DeepDiver1975
approved these changes
Jun 22, 2017
3 tasks
|
@butonic Backport to 10.0.x to release also with 10.0.4? |
|
@butonic please backport |
DeepDiver1975
pushed a commit
that referenced
this pull request
Nov 3, 2017
#28144) * use X-Request-ID header if provided by client * allow a few more chars to enable timestamps, add tests * fix regex and update exception message
|
stable10: #29434 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If clients send a request id we can identify the client request also in the apache and owncloud logs.
for apache the log rule needs to log the X-Request-ID environment variable
related:
also see