Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to deepdiver/zipstreamer 1.1.0 #29119

Merged
merged 1 commit into from
Oct 5, 2017
Merged

Switch to deepdiver/zipstreamer 1.1.0 #29119

merged 1 commit into from
Oct 5, 2017

Conversation

DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Sep 28, 2017

Description

Use fork of zipstreamer library which fixes warning about the archive being corrupted

Related Issue

#25580

Motivation and Context

Show no error ...

How Has This Been Tested?

Manual testing

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@davitol
Copy link
Contributor

davitol commented Oct 5, 2017

@DeepDiver1975 Tested and it doesn't solve the issue #25580 for me.
I still get the message:

unzip -T download.zip
note: didn't find end-of-central-dir signature at end of central dir.

@DeepDiver1975
Copy link
Member Author

THX for testing @davitol - so the unzip -T issues is not solved - which was never target ;-)

Please make sure that 7z works.

@davitol
Copy link
Contributor

davitol commented Oct 5, 2017

@DeepDiver1975 7z x download.zip went fine

@DeepDiver1975
Copy link
Member Author

@DeepDiver1975 7z x download.zip went fine

treating as approval -> merge

@lock
Copy link

lock bot commented Aug 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants