Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] Remove alternate keys storage during user delete #29155

Merged

Conversation

sharidas
Copy link
Contributor

@sharidas sharidas commented Oct 6, 2017

When user is deleted the alternate key storage location
does have folder with username. So while deleting user
this should also be cleaned up.

Signed-off-by: Sujith H sharidasan@owncloud.com

Description

Remove alternate key storage location during user delete process.

Related Issue

#26936

Motivation and Context

When user is deleted, the alternate key storage location which has folder name with username should
also be deleted.

How Has This Been Tested?

  • enable encryption with user keys
  • Using change-key-storage-root command move the keys to folder enckeys
  • Create another user user1 apart from user admin
  • Login as user1
  • Logout from user1 and login as admin
  • Delete the user1, there shouldn't be any traces of user1 inside the folder enckeys

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@sharidas sharidas self-assigned this Oct 6, 2017
@sharidas sharidas requested a review from DeepDiver1975 October 6, 2017 07:07
@sharidas sharidas force-pushed the remove-alternate-key-storage-user-delete-stable10 branch 2 times, most recently from c4fc15c to 9dba600 Compare October 6, 2017 15:27
When user is deleted the alternate key storage location
does have folder with username. So while deleting user
this should also be cleaned up.

Signed-off-by: Sujith H <sharidasan@owncloud.com>
@sharidas sharidas force-pushed the remove-alternate-key-storage-user-delete-stable10 branch from 9dba600 to e05d242 Compare October 6, 2017 15:44
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81
Copy link
Contributor

PVince81 commented Oct 9, 2017

restarted Jenkins job

@PVince81 PVince81 added this to the development milestone Oct 9, 2017
@sharidas sharidas merged commit b846f61 into stable10 Oct 10, 2017
@sharidas sharidas deleted the remove-alternate-key-storage-user-delete-stable10 branch October 10, 2017 12:37
@lock
Copy link

lock bot commented Aug 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants