[stable10] Disable background scan for home storage/cache #29306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The home cache might have entries with size=-1 that are outside of "files/" due to encryption or other metadata that generally do not require the size to be set or accurate. Instead of adjusting the HomeCache to ignore entries outside of "files/", let's just disable it completely. The home storage is in the data folder and must not receive external changes, so it should never have any entries with size=-1 in "files/".
Codecov Report
@@ Coverage Diff @@
## stable10 #29306 +/- ##
==============================================
+ Coverage 58.4% 58.4% +<.01%
- Complexity 17693 17694 +1
==============================================
Files 1059 1059
Lines 59341 59343 +2
==============================================
+ Hits 34657 34659 +2
Misses 24684 24684
Continue to review full report at Codecov.
|
PVince81
deleted the
stable10-343af394eca914b610aa61ff5e201e2e93a58ca7
branch
87 tasks
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The home cache might have entries with size=-1 that are outside of
"files/" due to encryption or other metadata that generally do not
require the size to be set or accurate.
Instead of adjusting the HomeCache to ignore entries outside of
"files/", let's just disable it completely. The home storage is in the
data folder and must not receive external changes, so it should never
have any entries with size=-1 in "files/".
backport of #28987 to stable10