Improve public link sharing permissions for folders

[felixheidecke]

Description

• Rework permissions in UX friendlier radio-button style.
• Improve modal behavior on mobile devices.

Related Issue

Fixes: #29116
Fixes: https://github.com/owncloud/enterprise/issues/2184

Motivation and Context

Currently the meaning of the option "Allow editing" (Download/Upload/Rename/Delete/Move) essentially changes to "Allow upload" (Upload only) when the second option "Show file listing" is unticked. This is inconsistent and can be very confusing for users. Moreover we thought a lot about how to make the file drop feature better understandable.

How Has This Been Tested?

Visual test only

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[codecov]

Codecov Report

Merging #29376 into master will increase coverage by 0.29%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #29376      +/-   ##
============================================
+ Coverage     60.21%   60.51%   +0.29%     
- Complexity    17188    17193       +5     
============================================
  Files          1030     1031       +1     
  Lines         57274    57288      +14     
============================================
+ Hits          34490    34667     +177     
+ Misses        22784    22621     -163

Impacted Files	Coverage Δ	Complexity Δ
settings/templates/panels/admin/filesharing.php	100% <0%> (ø)	0% <0%> (ø)	⬇️
apps/files_sharing/lib/Capabilities.php	100% <0%> (ø)	6% <0%> (ø)	⬇️
settings/Panels/Admin/FileSharing.php	100% <0%> (ø)	6% <0%> (ø)	⬇️
core/Migrations/Version20171026130750.php	0% <0%> (ø)	2% <0%> (?)
lib/private/Share20/Manager.php	97.25% <0%> (+0.01%)	198% <0%> (+1%)	⬆️
lib/private/Share/Share.php	66.87% <0%> (+0.09%)	502% <0%> (+2%)	⬆️
apps/files_sharing/lib/ShareBackend/File.php	24.77% <0%> (+0.91%)	35% <0%> (ø)	⬇️
lib/public/Share.php	61.81% <0%> (+3.63%)	26% <0%> (ø)	⬇️
...files_sharing/lib/Controller/ShareesController.php	89.03% <0%> (+72.73%)	93% <0%> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 214d030...6bc5e61. Read the comment docs.

[haukman]

@felixheidecke

I tried to apply the patch to a clean 10.0.3 without success:

root@ubuntu:/var/www/owncloud# patch -p1 < file.patch
patching file apps/files_sharing/css/sharetabview.css
patching file core/css/jquery.ocdialog.css
Hunk #1 FAILED at 8.
1 out of 1 hunk FAILED -- saving rejects to file core/css/jquery.ocdialog.css.rej
patching file core/js/jquery.ocdialog.js
Hunk #3 succeeded at 143 (offset 16 lines).
Hunk #4 succeeded at 154 (offset 16 lines).
patching file core/js/sharedialoglinkshareview.js

Am I doing somehting wrong?

[haukman]

I tested the three radio buttons and everything worked fine.

[PVince81]

👍

[PVince81]

@felixheidecke please backport to stable10

[PVince81]

stable10: #29413

@felixheidecke please always post link to backport, it's easier to find and more readable and triggers a github notification.

[michaelstingl]

@felixheidecke love PR's with screenshots 😍 !!!

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.