Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use Provisioning API for user administration in UI tests #29711

Merged
merged 1 commit into from
Dec 4, 2017
Merged

use Provisioning API for user administration in UI tests #29711

merged 1 commit into from
Dec 4, 2017

Conversation

individual-it
Copy link
Member

Description

creating/deleting and modifying users in the UI tests is done through the provisioning API and not by occ

Motivation and Context

the main goal is to make it possible to run UI tests against a remote instance, e.g. inside docker. See also https://github.com/owncloud/qa-enterprise/pull/115

One test fails because of #29698

How Has This Been Tested?

run tests in travis

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@individual-it individual-it added this to the development milestone Nov 29, 2017
@individual-it individual-it self-assigned this Nov 29, 2017
phil-davis
phil-davis approved these changes Nov 29, 2017
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you feel like changing just 2 comment lines.

tests/ui/features/bootstrap/BasicStructure.php Outdated
@@ -241,17 +270,39 @@ public function regularGroupsExist() {
* creates a single group
*
* @param string $group
* @param string $method how to create the user api|occ
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method creates a group

tests/ui/features/bootstrap/BasicStructure.php Outdated
@@ -272,16 +323,38 @@ public function aRegularUserIsInARegularGroup() {
* @Given the user :user is in the group :group
* @param string $user
* @param string $group
* @param string $method how to create the user api|occ
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how to add the user to the group

@individual-it individual-it force-pushed the ui-tests-create-user-by-api branch from 869c024 to 31a74f8 Compare November 29, 2017 04:22
@codecov
Copy link

codecov bot commented Nov 29, 2017 •
edited
Loading

Codecov Report

Merging #29711 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #29711   +/-   ##
=========================================
  Coverage     62.61%   62.61%           
  Complexity    17581    17581           
=========================================
  Files          1037     1037           
  Lines         57914    57914           
=========================================
  Hits          36263    36263           
  Misses        21651    21651

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91defa0...da5ac8b. Read the comment docs.

@phil-davis
Copy link
Contributor

@individual-it test fails because it cannot create a group named "0" using the API. So either need to get the fix for that in, or skip group zero from the test.

@individual-it
Copy link
Member Author

the tests was put in place to test #29051

@phil-davis phil-davis mentioned this pull request Nov 29, 2017
Merged
9 tasks
@phil-davis
Copy link
Contributor

@individual-it group 0 fix is now merged in master. Rebase this PR and it should pass.

@individual-it individual-it force-pushed the ui-tests-create-user-by-api branch from 31a74f8 to cac0fae Compare December 1, 2017 07:24
@individual-it individual-it force-pushed the ui-tests-create-user-by-api branch from cac0fae to da5ac8b Compare December 4, 2017 08:21
@individual-it individual-it mentioned this pull request Dec 4, 2017
Merged
@individual-it individual-it merged commit 7794d85 into master Dec 4, 2017
@individual-it individual-it deleted the ui-tests-create-user-by-api branch December 4, 2017 11:19
@lock
Copy link

lock bot commented Aug 1, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@patrickjahns patrickjahns Awaiting requested review from patrickjahns

@SergioBertolinSG SergioBertolinSG Awaiting requested review from SergioBertolinSG

@davitol davitol Awaiting requested review from davitol

Assignees

@individual-it individual-it

Labels
3 - To Review dev:acceptance-tests QA status/STALE
Projects
None yet
Milestone
10.0.5
Development

Successfully merging this pull request may close these issues.
3 participants
@individual-it @phil-davis @ownclouders