Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put back Firefox IE Edge UI tests #30223

Merged
merged 2 commits into from
Jan 23, 2018
Merged

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Jan 22, 2018

Description

  • revert the recent commit that temporarily removed almost all UI testing from Travis
  • run chrome UI tests only for stable10 and/or the cron job (like done for Firefox, IE and Edge)

Motivation and Context

It is good to run the UI tests on other browsers on some regular basis. This will run them again once a day. As discussed, also run chrome daily here, since it proves chrome on Windows (whereas drone is running chrome on Ubuntu). Keep running chrome in stable10 for backport PRs since UI tests are not yet running on drone in stable10.

How Has This Been Tested?

We will know only after merging and observing a daily Travis cron job run.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@phil-davis
Copy link
Contributor Author

Notes:

  1. timing of when to merge this is subject to discussion among QA team
  2. running Firefox UI tests on drone may also be done soon - but it will be easy to separately remove Firefox UI tests from Travis when that happens.

@codecov
Copy link

codecov bot commented Jan 22, 2018

Codecov Report

Merging #30223 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #30223   +/-   ##
=========================================
  Coverage     58.36%   58.36%           
  Complexity    18566    18566           
=========================================
  Files          1093     1093           
  Lines         63772    63772           
=========================================
  Hits          37222    37222           
  Misses        26550    26550

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2763603...515f0c8. Read the comment docs.

@phil-davis
Copy link
Contributor Author

@individual-it this should be now as discussed. Ready for review.

@phil-davis phil-davis force-pushed the put-back-IE-Edge-UI-tests branch from 5f8a618 to 515f0c8 Compare January 23, 2018 11:13
@phil-davis phil-davis merged commit 5c7912e into master Jan 23, 2018
@phil-davis phil-davis deleted the put-back-IE-Edge-UI-tests branch January 23, 2018 13:35
@lock
Copy link

lock bot commented Aug 1, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants