Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scenarios for transferring folders without files #30601

Merged
merged 1 commit into from
Feb 26, 2018

Conversation

phil-davis
Copy link
Contributor

Description

Add 2 new scenarios:

  1. A folder containing just a subfolder can be transferred, and the folder with sub-folder is received.
  2. When the root contains just an empty folder and nothing else - the empty folder is transferred.

Related Issue

#24061

Motivation and Context

We should test that sub-folders inside the requested folder are transferred to the new owner in the case where there are only sub-folders and no actual files. This will prevent possible regression of this desired behavior.

How Has This Been Tested?

New scenarios run locally.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Feb 25, 2018

Codecov Report

Merging #30601 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #30601      +/-   ##
============================================
+ Coverage     61.82%   61.83%   +0.01%     
- Complexity    19051    19055       +4     
============================================
  Files          1089     1089              
  Lines         61442    61457      +15     
============================================
+ Hits          37988    38004      +16     
+ Misses        23454    23453       -1
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Cache/Propagator.php 98.7% <0%> (+1.29%) 16% <0%> (ø) ⬇️
lib/private/User/BasicAuthModule.php 97.29% <0%> (+1.84%) 15% <0%> (+4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48ef206...dd747a2. Read the comment docs.

@phil-davis
Copy link
Contributor Author

Backport stable10 #30611

@lock
Copy link

lock bot commented Jul 31, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants