Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove WebUi for setup/installation - 10.1/11 will require terminal a… #30757

Closed
wants to merge 4 commits into from

Conversation

DeepDiver1975
Copy link
Member

…ccess

Description

Terminal access to the hosting web server is required. To install and update ownCloud use the occ commands.

Related Issue

Motivation and Context

  • minimize core code base
  • installing on terminal is more secure

screenshot from 2018-03-13 01-11-24

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Mar 13, 2018

Codecov Report

Merging #30757 into master will increase coverage by 0.26%.
The diff coverage is 1.78%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #30757      +/-   ##
============================================
+ Coverage     61.98%   62.24%   +0.26%     
+ Complexity    18369    18343      -26     
============================================
  Files          1157     1153       -4     
  Lines         69080    68785     -295     
  Branches       1242     1242              
============================================
- Hits          42818    42816       -2     
+ Misses        25890    25597     -293     
  Partials        372      372
Flag Coverage Δ Complexity Δ
#javascript 52.33% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 63.37% <1.78%> (+0.29%) 18343 <1> (-26) ⬇️
Impacted Files Coverage Δ Complexity Δ
core/routes.php 62.96% <ø> (-2.56%) 0 <0> (ø)
lib/base.php 4.51% <0%> (+0.3%) 148 <0> (-5) ⬇️
core/templates/update.use-cli.php 0% <0%> (ø) 0 <0> (ø) ⬇️
core/Command/Maintenance/Install.php 0% <0%> (ø) 21 <0> (+1) ⬆️
lib/private/Setup.php 15.9% <3.33%> (-0.61%) 53 <1> (+4)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7273799...158b5ce. Read the comment docs.

@PVince81
Copy link
Contributor

will it display a page that prompts the admin to do the setup process on the command line ?

nice to have: also add a hint that one needs to adjust config.php directly after that, especially the parts about "overwrite.cli.url"

@DeepDiver1975
Copy link
Member Author

will it display a page that prompts the admin to do the setup process on the command line ?

yes - see the screenshot above - something nicer could be invented ....

nice to have: also add a hint that one needs to adjust config.php directly after that, especially the parts about "overwrite.cli.url"

I want to add this as parameter / question during ./occ m:i

@GrendelOnCampus
Copy link

For enterprise users it's a good idea. but home users could be unable to cope. (on NAS devices, Ubuntu users...)

@phil-davis
Copy link
Contributor

And there are providers who "auto-setup" an ownCloud for you, and you (as the end-user) have an ownCloud admin webUI login, but no command line access yourself.

You can press the "update" button in the webUI when a new version is out, and you want it. With this change, people on those providers will be left without being able to do updates, or the provider is going to have to decide if they will do the updates on behalf of the end-users.

Will that be an issue for those kind of providers?

@DeepDiver1975
Copy link
Member Author

but home users could be unable to cope. (on NAS devices, Ubuntu users...)

I understand your point - but there are much more tasks through out the life time of ownCloud which are hard to almost undoable without terminal access.

We need to teach our user base to use the terminal. Anything else will only cause frustration in later stages.

To me the web based installer is a tool to fastly lockin users to ownCloud and keeps them locked in 😄 ....

@GrendelOnCampus
Copy link

@DeepDiver1975:
Myself, I am a Linux admin since many years. I learned with systems like SCO Xenix/SCO Unix more than 30 years ago. GUI? What's that? Ok, for me, using the commandline is no problem.
Other users use tools like Synaptic and expect a GUI to set up the system. On NAS you are told not to use SSH due to warranty & support terms.
I installed the last instances of ownCloud/sciebo via terminal access and I like that. But I'm having all the less experienced users in mind. I've been noticing the "fight" between ownCloud (which I stll prefer) and NextCloud. You might lose many of true users, let them join the "dark side" and use NextCloud.
I guess, we'll have to compromise. Terminal setup for experienced admins and designed as the favourite way to set up an ownCloud instance. But for all those, who can't, you still will need a GUI and/or web based tool for setting up the system. Maybe you can do this as an external application, of course. But I won't lock those less experienced users out. But this is just my point of view.

@KharmaScribbles
Copy link

There are so many ways to get terminal or SSH access;, even ChromeOS users have access to SSH via a Chrome Web App.

GCP, AWS.. don't even need to spin up an instance (at least with GCP)

I duel boot ChromeOS and GalliumOS (KUbuntu deriv.)

Linux is very, VERY foreign to me, and when I was a Windows user I never so much as edited or viewed a system file. NEVER used command-line but once when I had to debug a Runescape client. It involved typing rcmd and something.

Since discovering Linux, now, I try to find out if there is a script or program with CLI implementation before going with a GUI client (or at least, if the GUI program has a command-line option). I use Lynx and Irssi for examples.. I'm currently looking for the best implementation of a BashBlog static site generator/markup compiler.

I'm a complete newb, and still not sure if I know what "regular expression" means, as an example to my newbness.
Linux, Bash, Terminal.. ? IFs ANDs and .. whats? Completely lost most days, but that doesn't take much either ;)

All this is another language to me but I'm feeling so challenged and eager to learn it so I can use it like it's second nature. I've been on the internet 15 years and I feel like I'm learning how to play Reader Rabbit all over again.

It's the year of the Linux desktop, btw.

The more informed a user is about the all-powerful CLI, the better our technological advancement for the future.
.
As a server admin, I would love to have this as an option, to only allow users who have access to a terminal program, to use OwnCloud.. The more minimilist the code I need to install to my server, the more I want it.

Considering I will be installing OwnCloud for the first time, my fresh install would allow me the freedom to screen who is able to end up using my instance.

Just an opinion I wanted to share. I'm in the..28-31 age bracket if that helps at all.

@felixboehm felixboehm modified the milestones: development, planned Apr 10, 2018
@mmattel
Copy link
Contributor

mmattel commented Apr 10, 2018

@settermjd FYI when merged, documentation relevant.

@drknorke
Copy link

drknorke commented May 3, 2018

guys, i like the attitude that everybody setting up a cloud should be able to work with a terminal. those who can't should learn it, it's not an extremely big deal and actually it makes no sense to play admin without a certain background knowledge. so, yes, everybody should learn to use the terminal. indeed, i would love to talk to owncloud via terminal. however, my cloud is on a hosted server without any ssh access. so i cannot. period. just as many other users i know. it's a big german hoster and they even offer a three click fresh install of the most up-to-date stable owncloud version because many people use owncloud exactly that way. but i am pretty sure that they won't do manual updates and trouble-shooting for you on a regular basis. since neither doing fresh installs whenever there is a new update nor doing no updates at all is definitely no option, you will loose many users when abandoning the updater app. and their personal attitude towards the terminal plays no role in that case.

@PVince81 PVince81 removed this from the triage milestone May 22, 2018
@PVince81 PVince81 added this to the maybe some day milestone May 22, 2018
@PVince81
Copy link
Contributor

PVince81 commented Nov 7, 2018

considering that Phoenix will be the new frontend in OC 11, if we want a setup UI it would need to be rebuild it in Phoenix for "single node" installations.

for people setting up the frontend on a separate server, the backend will need to be installed on CLI

@DeepDiver1975
Copy link
Member Author

In a full blown Phoenix setup i See docker (with maybe docker composer) as the only simplified Setup mechanism for the Future.

In such a scenario you anyhow have ssh access or use docker exec to get a bash.

@DeepDiver1975 DeepDiver1975 deleted the terminal-access-is-required branch February 5, 2019 14:34
settermjd added a commit to owncloud/docs that referenced this pull request Nov 11, 2019
This is required as the functionality is no longer supported, thanks to
being removed in owncloud/core#30757.

This relates to owncloud/core#31073, and
owncloud/core#36044.
@lock lock bot locked as resolved and limited conversation to collaborators Feb 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants