Run API acceptance tests on drone

[phil-davis]

Description

Implement API acceptance tests item in drone pipeline

Related Issue

Motivation and Context

Progress moving stuff off Jenkins and onto drone.

How Has This Been Tested?

CI

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Test refactoring

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[codecov]

Codecov Report

Merging #30900 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #30900   +/-   ##
=========================================
  Coverage     62.25%   62.25%           
  Complexity    18212    18212           
=========================================
  Files          1141     1141           
  Lines         68065    68065           
  Branches       1230     1230           
=========================================
  Hits          42375    42375           
  Misses        25327    25327           
  Partials        363      363

Flag	Coverage Δ	Complexity Δ
#javascript	51.99% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	63.42% <ø> (ø)	18212 <ø> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f40fb0...a399715. Read the comment docs.

[phil-davis]

This is just the first commit from #30883

If people are happy, we could merge this, and backport. Then as the next step, we reorganize the API acceptance apiMain suite into smaller pieces.

This means that issues with reorganizing the API acceptance suites can be dealt with cleanly and separately to the move to drone.

[SergioBertolinSG]

@phil-davis what is the difference with #30883 ? and why not improving it there or closing if it is discarded?

[phil-davis]

This PR just adds the scripts and jobs in drone to run API acceptance tests for each of the existing API acceptance test suites. It is the smallest change.

There are issues that are seen on Jenkins if I split the suites up more and rearrange them. This seems to be for some tests that check a public link with password download, and require federated sharing to be enabled. When I try running some "new" combinations of suite order, then those tests fail. I am looking at that now as a separate issue. It is an existing problem with the API acceptance tests, not one that is actually caused by drone.

[phil-davis]

So I am asking if people are willing to merge this PR. And I can look into the other issues separately.

[phil-davis]

@patrickjahns @SergioBertolinSG please give an opinion. I do not want to merge with just @individual-it approval in this case.

[phil-davis]

Backport stable10 #30923

[SergioBertolinSG]

@phil-davis here I also see the problem with changing permissions when running the tests locally:

PHP_VERSION=7.1 DB_TYPE=mariadb USE_SERVER=true INSTALL_SERVER=true CHOWN_SERVER=true OWNCLOUD_LOG=true BEHAT_SUITE=apiWebdav TEST_SUITE=api drone exec --commit-branch master --build-event push

[fix-permissions:L1:4s] chown: changing ownership of '/drone/src/build/bin/bower': No such file or directory
[fix-permissions:L2:21s] chown: changing ownership of '/drone/src/core/vendor': No such file or directory

[phil-davis]

Superseded by #30927

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.