Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isset spaces blankline code quality #31306

Closed
wants to merge 8 commits into from

Conversation

phil-davis
Copy link
Contributor

clean cherry-pick of commits in PR #31273

@phil-davis phil-davis added this to the development milestone Apr 30, 2018
@phil-davis phil-davis self-assigned this Apr 30, 2018
@phil-davis
Copy link
Contributor Author

OK, but incomplete, skipped, or risky tests!
Tests: 9596, Assertions: 42692, Skipped: 83.
./tests/drone/test-phpunit.sh: line 58: 68 Segmentation fault (core dumped) $phpunit_cmd --configuration tests/phpunit-autotest.xml ${GROUP} --coverage-clover tests/output/coverage/autotest-clover-"${DB_TYPE}".xml

in a phpunit sqlite drone job???

Restarted drone.

@codecov
Copy link

codecov bot commented Apr 30, 2018

Codecov Report

Merging #31306 into master will increase coverage by <.01%.
The diff coverage is 58.51%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #31306      +/-   ##
============================================
+ Coverage     62.58%   62.59%   +<.01%     
+ Complexity    18401    18227     -174     
============================================
  Files          1145     1145              
  Lines         68418    68414       -4     
  Branches       1234     1234              
============================================
- Hits          42822    42821       -1     
+ Misses        25235    25232       -3     
  Partials        361      361
Flag Coverage Δ Complexity Δ
#javascript 52.05% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 63.79% <58.51%> (ø) 18227 <39> (-174) ⬇️
Impacted Files Coverage Δ Complexity Δ
apps/systemtags/templates/list.php 0% <ø> (ø) 0 <0> (ø) ⬇️
lib/private/Files/Storage/Home.php 95.65% <ø> (ø) 10 <0> (ø) ⬇️
apps/files/lib/Command/Scan.php 80.91% <ø> (ø) 72 <0> (ø) ⬇️
apps/files_sharing/lib/API/Share20OCS.php 91.68% <ø> (ø) 153 <0> (ø) ⬇️
...pps/comments/tests/unit/Dav/CommentsPluginTest.php 100% <ø> (ø) 11 <0> (ø) ⬇️
apps/files_versions/lib/Command/Expire.php 100% <ø> (ø) 3 <0> (ø) ⬇️
lib/private/Files/External/DependencyTrait.php 0% <ø> (ø) 1 <0> (ø) ⬇️
...s/federation/lib/BackgroundJob/GetSharedSecret.php 63.33% <ø> (ø) 20 <0> (ø) ⬇️
...b/private/Files/ObjectStore/ObjectStoreStorage.php 72.13% <ø> (ø) 91 <0> (ø) ⬇️
lib/private/App/CodeChecker/CodeChecker.php 41.66% <ø> (ø) 12 <0> (ø) ⬇️
... and 267 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41606ad...3bbf8ca. Read the comment docs.

@phil-davis
Copy link
Contributor Author

Code coverage results are the same as for the mother PR.

@phil-davis
Copy link
Contributor Author

Closing - code coverage test is done.

@phil-davis phil-davis closed this Apr 30, 2018
@phil-davis phil-davis deleted the isset-spaces-blankline-code-quality branch April 30, 2018 09:26
@PVince81 PVince81 modified the milestones: development, QA Jun 13, 2018
@lock
Copy link

lock bot commented Jul 30, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants