-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Splitting apiSharing feature file into different files #31422
Splitting apiSharing feature file into different files #31422
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a reasonable first split of the existing sharing scenarios. Now the plan is to look at each of these feature files and reorganize/expand the test scenarios to achieve a sensible level of API acceptance test coverage of each feature.
During that process, some feature files may be split into more pieces. Because actually there will be quite a lot of scenarios for this stuff, taking into account the various permission combinations, user/group/public... share types and all the things a share receiver can and cannot do with each combination.
This will be "interesting" to backport. First compare the "old" sharing feature file in |
Codecov Report
@@ Coverage Diff @@
## master #31422 +/- ##
=========================================
Coverage 62.64% 62.64%
Complexity 18255 18255
=========================================
Files 1145 1145
Lines 68481 68481
Branches 1234 1234
=========================================
Hits 42898 42898
Misses 25222 25222
Partials 361 361
Continue to review full report at Codecov.
|
Backport on #31423 |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
The apiSharing feature file is now split into other small manageable feature files
Related Issue
#31531
Motivation and Context
To make adding more tests easier
How Has This Been Tested?
Locally
Types of changes