API test for downloadFromShare #31458
Conversation
| | /textfile0%20(2).txt | | ||
|
|
||
| Scenario: Downloading file inside the folder which is inside the user shared folder |
There was a problem hiding this comment.
This is not quite clear to me - do you have an example?
There was a problem hiding this comment.
Download a file that is in a folder contained in a folder that has been shared with a user
| And user "user1" has been created | ||
| And user "user0" creates a share using the API with settings | ||
| | path | PARENT | |
There was a problem hiding this comment.
Make the middle | line up also
| | shareType | 0 | | ||
| | shareWith | user1 | | ||
| Then the user "user1" should be able to download the file "/CHILD/child.txt" using the API |
There was a problem hiding this comment.
As discussed - this should give the full path like "/PARENT (2)/CHILD/child.txt"
| Then the user "user1" should be able to download the file "/CHILD/child.txt" using the API | ||
|
|
||
| Scenario: Downloading file inside the folder which is inside the group shared folder |
There was a problem hiding this comment.
Download a file that is in a folder contained in a folder that has been shared with a group
| Then the user "user1" should be able to download the file "/CHILD/child.txt" using the API | ||
|
|
||
| Scenario: Downloading file inside the folder which is inside the public shared folder |
There was a problem hiding this comment.
Download a file that is in a folder contained in a folder that has been shared with public
| Then the public should be able to download the range "bytes=1-7" of file "/CHILD/child.txt" from inside the last public shared folder with password "publicpw" and the content should be "wnCloud" | ||
|
|
||
| Scenario: Downloading file inside the folder which is inside the user shared folder with share permission read/write |
There was a problem hiding this comment.
Make similar changes here to the words
|
I think the first scenarios already default to read/write. So we should mention that. |
paurakhsharma
force-pushed
the
API-test-downloadFromShare
branch
2 times, most recently
from
8124f90 to
90587ff
Compare
There was a problem hiding this comment.
Note: createShare.feature verifies that the share was created by testing that a file can be downloaded from the root folder of the share. So that means that createShare effectively has scenarios that test creating a share and being able to download from the share as a single scenario.
For that reason, the scenarios here in downloadFromShare are testing the case of downloading from a sub-folder inside the share - which is something different that needs to be tested.
|
Backport on #31459 |
paurakhsharma
force-pushed
the
API-test-downloadFromShare
branch
from
90587ff to
6fec518
Compare
Codecov Report
@@ Coverage Diff @@
## master #31458 +/- ##
=========================================
Coverage 62.65% 62.65%
Complexity 18248 18248
=========================================
Files 1145 1145
Lines 68464 68464
Branches 1234 1234
=========================================
Hits 42897 42897
Misses 25206 25206
Partials 361 361
Continue to review full report at Codecov.
|
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
This PR adds more tests for download from share
Related Issue
#31531
How Has This Been Tested?
Locally
Types of changes
Checklist: