Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API test for getWebDAVSharePermissions #31534

Merged

Conversation

paurakhsharma
Copy link
Member

Description

This PR adds more tests for get webDAV share permissions

Related Issue

#31531

How Has This Been Tested?

Locally

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Acceptance test

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just words in scenario descriptions

|{http://open-collaboration-services.org/ns}share-permissions |
Then the single response should contain a property "{http://open-collaboration-services.org/ns}share-permissions" with value "17"

Scenario: Correct webdav share-permissions for received file with reshare permissions but no edit permissions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"received group shared file"

|{http://open-collaboration-services.org/ns}share-permissions |
Then the single response should contain a property "{http://open-collaboration-services.org/ns}share-permissions" with value "19"

Scenario: Correct webdav share-permissions for received group share file with edit and reshare permissions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/share file/shared file/g

@codecov
Copy link

codecov bot commented May 25, 2018

Codecov Report

Merging #31534 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #31534   +/-   ##
=========================================
  Coverage     62.61%   62.61%           
  Complexity    18273    18273           
=========================================
  Files          1147     1147           
  Lines         68627    68627           
  Branches       1234     1234           
=========================================
  Hits          42971    42971           
  Misses        25295    25295           
  Partials        361      361
Flag Coverage Δ Complexity Δ
#javascript 52.05% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 63.81% <ø> (ø) 18273 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 799beef...296d827. Read the comment docs.

@paurakhsharma paurakhsharma force-pushed the API-test-getWebDAVSharePermissions branch from 1ed1e8f to 296d827 Compare May 28, 2018 06:38
@paurakhsharma
Copy link
Member Author

Backport on #31575

@paurakhsharma paurakhsharma reopened this May 29, 2018
@phil-davis phil-davis merged commit db0a80d into owncloud:master May 29, 2018
@PVince81 PVince81 modified the milestones: development, QA Jun 13, 2018
@lock
Copy link

lock bot commented Jul 30, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants