Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API test for restoring version of shared file #31577

Merged
merged 1 commit into from
May 30, 2018

Conversation

paurakhsharma
Copy link
Member

Description

This PR adds more tests for version API acceptance test

Related Issue

#31535

How Has This Been Tested?

Locally

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Acceptance test

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented May 30, 2018

Codecov Report

Merging #31577 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #31577   +/-   ##
=========================================
  Coverage     62.61%   62.61%           
  Complexity    18274    18274           
=========================================
  Files          1147     1147           
  Lines         68627    68627           
  Branches       1234     1234           
=========================================
  Hits          42972    42972           
  Misses        25294    25294           
  Partials        361      361
Flag Coverage Δ Complexity Δ
#javascript 52.05% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 63.81% <ø> (ø) 18274 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4137b91...584c0a4. Read the comment docs.

@phil-davis phil-davis merged commit 163efd2 into owncloud:master May 30, 2018
@phil-davis
Copy link
Contributor

In another PR we can add scenarios for:

  • user0 shares a folder to user1

    • user0 puts a file in the folder, user1 modifies it, user0 can restore the old version
    • user0 puts a file in the folder, user1 modifies it, user1 can restore the old version
    • user1 puts a file in the folder, user0 modifies it, user0 can restore the old version
    • user1 puts a file in the folder, user0 modifies it, user1 can restore the old version
    • user1 puts a file in the folder, user1 modifies it, user0 can restore the old version (user1 is the only user who touched the file)
    • user0 puts a file in the folder, user0 modifies it, user1 can restore the old version (user1 is the only user who touched the file)
  • user0 shares a folder to a group, the users in the group modify files, old versions can be restored.

@paurakhsharma
Copy link
Member Author

Ok, I will be adding these scenarios in next PR

@phil-davis
Copy link
Contributor

phil-davis commented May 30, 2018

Note: the dav versions stuff has not been backported to stable10 yet, so it is not possible to backport these extra scenarios.

Edit: the commit in this PR has been cherry-picked into backport PR #31050

@lock
Copy link

lock bot commented Jul 30, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants