API test for disableSharing #31674

paurakhsharma · 2018-06-07T09:02:54Z

Description

This PR adds test to check API behavior when link sharing is disabled.

Related Issue

#31531

How Has This Been Tested?

Locally

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Acceptance test

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.

phil-davis

We could also add scenarios that try to share a folder, and make sure that does not work.

phil-davis · 2018-06-07T10:19:01Z

tests/acceptance/features/apiSharing-v1/disableSharing.feature

+		And as user "admin"
+		When parameter "shareapi_enabled" of app "core" has been set to "no"
+		Then user "user0" should not be able to share file "welcome.txt" with user "user1" using the API
+		Then the OCS status code should be "404"


phil-davis · 2018-06-07T10:19:22Z

tests/acceptance/features/apiSharing-v1/disableSharing.feature

+		And as user "admin"
+		When parameter "shareapi_enabled" of app "core" has been set to "no"
+		Then user "user0" should not be able to share file "welcome.txt" with group "sharinggroup" using the API
+		Then the OCS status code should be "404"


phil-davis · 2018-06-07T10:19:50Z

tests/acceptance/features/apiSharing-v1/disableSharing.feature

+		Given using API version "1"
+		And using old DAV path
+
+	Scenario: user tries to share a file with another user when an sharing api has been disabled


s/an sharing api/the sharing api/

phil-davis · 2018-06-07T10:19:58Z

tests/acceptance/features/apiSharing-v1/disableSharing.feature

+		Then the OCS status code should be "404"
+		And the HTTP status code should be "200"
+
+	Scenario: user tries to share a file with group when an sharing api has been disabled


s/an sharing api/the sharing api/

phil-davis · 2018-06-07T10:24:42Z

tests/acceptance/features/bootstrap/Sharing.php

+		$options['auth'] = $this->getAuthOptionForUser($sharer);
+		$this->response = $client->get($fullUrl, $options);
+		if ($this->isUserOrGroupInSharedData($sharee, $permissions)) {
+			return;


Why do we need to do this check?
If it returns true here then this return will make this step pass.

paurakhsharma · 2018-06-07T10:43:46Z

What are other scenarios you think I should add here? I will add scenarios for public share after #31677 is merged.

codecov · 2018-06-07T10:51:08Z

Codecov Report

Merging #31674 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #31674   +/-   ##
=========================================
  Coverage     62.89%   62.89%           
  Complexity    18418    18418           
=========================================
  Files          1154     1154           
  Lines         69157    69157           
  Branches       1260     1260           
=========================================
  Hits          43499    43499           
  Misses        25289    25289           
  Partials        369      369

Flag	Coverage Δ	Complexity Δ
#javascript	`52.39% <ø> (ø)`	`0 <ø> (ø)`	⬇️
#phpunit	`64.1% <ø> (ø)`	`18418 <ø> (ø)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94d8747...02c598b. Read the comment docs.

phil-davis · 2018-06-07T11:32:15Z

This seems a good set of tests. So I will merge when CI finishes.

phil-davis · 2018-06-07T12:23:56Z

php-cs-fixer failed:

   1) tests/acceptance/features/bootstrap/Sharing.php (class_definition, method_argument_space, braces)
      ---------- begin diff ----------
--- Original
+++ New
@@ -432,7 +432,7 @@
 	 * @return void
 	 */
 	public function shouldNotBeAbleToCreatePublicShare($sharer, $filepath) {
-		$this->createAPublicShare($sharer,  $filepath);
+		$this->createAPublicShare($sharer, $filepath);
 		PHPUnit_Framework_Assert::assertEquals(
 			404,
 			$this->getOCSResponseStatusCode($this->response)

      ----------- end diff -----------

It is good to do:

make test-php-style

before pushing code up. That saves having these annoying little format issues.

I removed the extra space, squash, rebased...

paurakhsharma · 2018-06-07T13:30:22Z

Thank you, @phil-davis I will remember it form next time.

paurakhsharma · 2018-06-08T08:44:34Z

Backport on #31694

phil-davis · 2018-06-08T09:26:02Z

1 line of code was bonus unused - see PR #31695
I have added that commit to the backport.

lock · 2019-07-31T06:01:47Z

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

paurakhsharma added 2 - Developing dev:acceptance-tests labels Jun 7, 2018

paurakhsharma added this to the development milestone Jun 7, 2018

paurakhsharma self-assigned this Jun 7, 2018

paurakhsharma requested a review from phil-davis June 7, 2018 09:02

paurakhsharma force-pushed the API-test-disableSharing branch from 48fff14 to e72d848 Compare June 7, 2018 09:55

phil-davis reviewed Jun 7, 2018

View reviewed changes

paurakhsharma force-pushed the API-test-disableSharing branch 2 times, most recently from 8e0ec7b to 6fad514 Compare June 7, 2018 10:40

paurakhsharma force-pushed the API-test-disableSharing branch from 6fad514 to 0dbf7a3 Compare June 7, 2018 10:56

paurakhsharma added 3 - To Review and removed 2 - Developing labels Jun 7, 2018

phil-davis approved these changes Jun 7, 2018

View reviewed changes

phil-davis added the backport-request label Jun 7, 2018

API test for disableSharing

02c598b

phil-davis force-pushed the API-test-disableSharing branch from 0dbf7a3 to 02c598b Compare June 7, 2018 12:22

paurakhsharma merged commit 649c57c into master Jun 7, 2018

phil-davis deleted the API-test-disableSharing branch June 7, 2018 13:43

paurakhsharma mentioned this pull request Jun 8, 2018

[stable10] API test for disableSharing #31694

Merged

paurakhsharma removed the backport-request label Jun 8, 2018

phil-davis mentioned this pull request Jun 8, 2018

Remove unused code in acceptance tests Sharing.php #31695

Merged

10 tasks

PVince81 modified the milestones: development, QA Jun 13, 2018

lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

API test for disableSharing #31674

API test for disableSharing #31674

paurakhsharma commented Jun 7, 2018

phil-davis left a comment

phil-davis Jun 7, 2018

phil-davis Jun 7, 2018

phil-davis Jun 7, 2018

phil-davis Jun 7, 2018

phil-davis Jun 7, 2018

paurakhsharma commented Jun 7, 2018

codecov bot commented Jun 7, 2018 •

edited

Loading

phil-davis commented Jun 7, 2018

phil-davis commented Jun 7, 2018

paurakhsharma commented Jun 7, 2018

paurakhsharma commented Jun 8, 2018

phil-davis commented Jun 8, 2018

lock bot commented Jul 31, 2019

API test for disableSharing #31674

API test for disableSharing #31674

Conversation

paurakhsharma commented Jun 7, 2018

Description

Related Issue

How Has This Been Tested?

Types of changes

Checklist:

phil-davis left a comment

Choose a reason for hiding this comment

phil-davis Jun 7, 2018

Choose a reason for hiding this comment

phil-davis Jun 7, 2018

Choose a reason for hiding this comment

phil-davis Jun 7, 2018

Choose a reason for hiding this comment

phil-davis Jun 7, 2018

Choose a reason for hiding this comment

phil-davis Jun 7, 2018

Choose a reason for hiding this comment

paurakhsharma commented Jun 7, 2018

codecov bot commented Jun 7, 2018 • edited Loading

Codecov Report

phil-davis commented Jun 7, 2018

phil-davis commented Jun 7, 2018

paurakhsharma commented Jun 7, 2018

paurakhsharma commented Jun 8, 2018

phil-davis commented Jun 8, 2018

lock bot commented Jul 31, 2019

codecov bot commented Jun 7, 2018 •

edited

Loading