API test for disabled public upload share #31697

paurakhsharma · 2018-06-08T10:32:08Z

Description

This PR adds tests to:

Make sure public cannot upload a file to a shared folder when allow public upload is disabled.
Make sure publicly uploading to a publicly shared folder doesn't work when a folder has been shared after allow public upload has been disabled and again enabled after file has been shared.
Make sure publicly uploading to a publicly shared folder works if allow public upload is disabled and re-enabled after the folder has been shared

Related Issue

#31531

How Has This Been Tested?

Locally

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Acceptance test

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.

phil-davis

See comments

phil-davis · 2018-06-08T10:38:32Z

tests/acceptance/features/apiSharing-v1/uploadToShare.feature

+			| shareType   | 3      |
+			| permissions | 4      |
+		When parameter "shareapi_allow_public_upload" of app "core" has been set to "no"


Use the When form of this step:

When the administrator sets parameter "xyz" of app "core" to "no" using the API

phil-davis · 2018-06-08T10:38:48Z

tests/acceptance/features/apiSharing-v1/uploadToShare.feature

+			| shareType   | 3      |
+			| permissions | 4      |
+		When parameter "shareapi_allow_public_upload" of app "core" has been set to "yes"


Use the When form of this step:

When the administrator sets parameter "xyz" of app "core" to "no" using the API

phil-davis · 2018-06-08T10:39:30Z

tests/acceptance/features/apiSharing-v1/uploadToShare.feature

+		And the HTTP status code should be "403"
+
+	Scenario: Uploading file to a public shared folder does not work when allow public uploads has disabled before sharing and again enabled after sharing the folder


s/has disabled/has been disabled/

phil-davis · 2018-06-08T10:42:06Z

tests/acceptance/features/apiSharing-v1/uploadToShare.feature

+			| permissions | 4      |
+		When parameter "shareapi_allow_public_upload" of app "core" has been set to "yes"
+		Then publicly uploading a file should not work


Why "should not work"?
Is it because the share creation will have failed at line 247?

So you could write another scenario also that tests that:

Given parameter "shareapi_allow_public_upload" of app "core" has been set to "no" When user "user0" creates a share with settings: ...

then the status should be 4nn and the share should not exist.

No. line 247 should work fine.
I was about to talk to you about it. I think when public upload is disabled then all public shares created thereafter doesn't allow public uploading?

What happens when the share is created at line 247?
Does it get created, but without the requested public upload permission?
Or?

Sorry, the share doesn't get created. But if we share it with upload and read permission, it is created with read-only permission.

So in this scenario share is not created so line 251 doesn't make sense. So I think I should change this scenario to share with permission 31. I think that would make more sense?

phil-davis · 2018-06-08T10:42:33Z

tests/acceptance/features/apiSharing-v1/uploadToShare.feature

+		And the HTTP status code should be "401"
+
+	Scenario: Uploading file to a public shared folder works when allow public uploads has disabled and again enabled after sharing the folder


s/has disabled/has been disabled/

codecov · 2018-06-08T12:38:57Z

Codecov Report

Merging #31697 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #31697   +/-   ##
=========================================
  Coverage     62.89%   62.89%           
  Complexity    18417    18417           
=========================================
  Files          1154     1154           
  Lines         69156    69156           
  Branches       1260     1260           
=========================================
  Hits          43498    43498           
  Misses        25289    25289           
  Partials        369      369

Flag	Coverage Δ	Complexity Δ
#javascript	`52.39% <ø> (ø)`	`0 <ø> (ø)`	⬇️
#phpunit	`64.1% <ø> (ø)`	`18417 <ø> (ø)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed7c59a...b16165a. Read the comment docs.

paurakhsharma · 2018-06-11T08:21:26Z

Backport on #31707

lock · 2019-07-31T05:02:28Z

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

paurakhsharma added 3 - To Review dev:acceptance-tests labels Jun 8, 2018

paurakhsharma added this to the development milestone Jun 8, 2018

paurakhsharma self-assigned this Jun 8, 2018

paurakhsharma requested a review from phil-davis June 8, 2018 10:32

phil-davis reviewed Jun 8, 2018

View reviewed changes

paurakhsharma force-pushed the API-test-uploadToPublicShare branch from ec5ae7f to bba20ab Compare June 8, 2018 11:17

API test for disabled public upload share

b16165a

paurakhsharma force-pushed the API-test-uploadToPublicShare branch from bba20ab to b16165a Compare June 8, 2018 11:20

phil-davis approved these changes Jun 8, 2018

View reviewed changes

phil-davis merged commit d87999f into master Jun 8, 2018

phil-davis deleted the API-test-uploadToPublicShare branch June 8, 2018 13:07

phil-davis added the backport-request label Jun 8, 2018

paurakhsharma mentioned this pull request Jun 11, 2018

[Stable10] api test upload to public share #31707

Merged

paurakhsharma removed the backport-request label Jun 12, 2018

PVince81 modified the milestones: development, QA Jun 13, 2018

lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

API test for disabled public upload share #31697

API test for disabled public upload share #31697

paurakhsharma commented Jun 8, 2018

phil-davis left a comment

phil-davis Jun 8, 2018

phil-davis Jun 8, 2018

phil-davis Jun 8, 2018

phil-davis Jun 8, 2018

phil-davis Jun 8, 2018

paurakhsharma Jun 8, 2018

phil-davis Jun 8, 2018

paurakhsharma Jun 8, 2018 •

edited

Loading

paurakhsharma Jun 8, 2018

phil-davis Jun 8, 2018

codecov bot commented Jun 8, 2018 •

edited

Loading

paurakhsharma commented Jun 11, 2018

lock bot commented Jul 31, 2019

		And the HTTP status code should be "403"

		Scenario: Uploading file to a public shared folder does not work when allow public uploads has disabled before sharing and again enabled after sharing the folder

		And the HTTP status code should be "401"

		Scenario: Uploading file to a public shared folder works when allow public uploads has disabled and again enabled after sharing the folder

API test for disabled public upload share #31697

API test for disabled public upload share #31697

Conversation

paurakhsharma commented Jun 8, 2018

Description

Related Issue

How Has This Been Tested?

Types of changes

Checklist:

phil-davis left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

paurakhsharma Jun 8, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Jun 8, 2018 • edited Loading

Codecov Report

paurakhsharma commented Jun 11, 2018

lock bot commented Jul 31, 2019

paurakhsharma Jun 8, 2018 •

edited

Loading

codecov bot commented Jun 8, 2018 •

edited

Loading