API test for restrictSharingOutsideTheGroup #31715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phil-davis
reviewed
Jun 11, 2018
| And the OCS status code should be "403" | ||
| And the HTTP status code should be "200" | ||
|
|
||
| Scenario: user shares a file with user who is in his group when sharing outside the group has been restricted |
| And the OCS status code should be "100" | ||
| And the HTTP status code should be "200" | ||
|
|
||
| Scenario: user tries to share a file with the group he is not member of when sharing outside the group has been restricted |
| And the OCS status code should be "404" | ||
| And the HTTP status code should be "200" | ||
|
|
||
| Scenario: user shares a file with the group he is member of when sharing outside the group has been restricted |
| } | ||
|
|
||
| /** | ||
| * @Then /^user "([^"]*)" should be able to share (?:file|folder|entry) "([^"]*)" with group "([^"]*)"(?: with permissions ([\d]*))? using the API$/ |
There was a problem hiding this comment.
Can we make a single function with (user|group) then decide the 0|1 parameter to createShare() based on that?
It would save repeating all the other code around the createShare() calll.
Codecov Report
@@ Coverage Diff @@
## master #31715 +/- ##
=========================================
Coverage 63.14% 63.14%
Complexity 18438 18438
=========================================
Files 1158 1158
Lines 69259 69259
Branches 1260 1260
=========================================
Hits 43733 43733
Misses 25157 25157
Partials 369 369
Continue to review full report at Codecov.
|
paurakhsharma
force-pushed
the
API-test-sharing-restrictSharingOutsideTheGroup
branch
from
32323c2 to
7715908
Compare
phil-davis
approved these changes
Jun 12, 2018
|
Backport on #31736 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds test to check the behavior of sharing API when sharing outside the group has been restricted
Related Issue
#31531
How Has This Been Tested?
Locally
Types of changes
Checklist: