Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken web setup page #31757

Merged
merged 1 commit into from
Jun 13, 2018
Merged

Fix broken web setup page #31757

merged 1 commit into from
Jun 13, 2018

Conversation

VicDeo
Copy link
Member

@VicDeo VicDeo commented Jun 13, 2018

Description

Fix chicken-egg regression in OC_Defaults

Related Issue

Fixes #31741

Motivation and Context

Broken Web UI

How Has This Been Tested?

  1. git clone git@github.com:owncloud/core.git test-install
  2. cd test-install
  3. make
  4. Open it in browser

Expected

Setup page appears

Actual

Error page is printed

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@VicDeo VicDeo added this to the development milestone Jun 13, 2018
@VicDeo VicDeo self-assigned this Jun 13, 2018
@ownclouders ownclouders added Type:Bug p2-high Escalation, on top of current planning, release blocker regression sev1-critical labels Jun 13, 2018
@VicDeo VicDeo requested a review from PVince81 June 13, 2018 14:40
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm... ok, as @DeepDiver1975 proposed this.

This will need to be copied into example theme and others as well later on.

👍

@PVince81
Copy link
Contributor

uh oh, php-cs-fixer not happy

@codecov
Copy link

codecov bot commented Jun 13, 2018

Codecov Report

Merging #31757 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #31757      +/-   ##
============================================
+ Coverage     63.17%   63.17%   +<.01%     
- Complexity    18445    18448       +3     
============================================
  Files          1158     1158              
  Lines         69288    69294       +6     
  Branches       1261     1261              
============================================
+ Hits          43770    43776       +6     
  Misses        25148    25148              
  Partials        370      370
Flag Coverage Δ Complexity Δ
#javascript 52.47% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 64.4% <100%> (ø) 18448 <1> (+3) ⬆️
Impacted Files Coverage Δ Complexity Δ
lib/private/legacy/defaults.php 59.25% <100%> (+2.39%) 45 <1> (+3) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb379c1...a7be7e5. Read the comment docs.

@VicDeo
Copy link
Member Author

VicDeo commented Jun 13, 2018

Stable10: #31766

@mrow4a
Copy link
Contributor

mrow4a commented Jun 13, 2018

Tested, works 👍

@DeepDiver1975 DeepDiver1975 merged commit 742d088 into master Jun 13, 2018
@VicDeo VicDeo deleted the fix-31741 branch June 13, 2018 19:25
@lock
Copy link

lock bot commented Jul 30, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3 - To Review p2-high Escalation, on top of current planning, release blocker regression sev1-critical Type:Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup page for stable10 / 10.0.9beta broken, chicken-egg problem
6 participants