Handle SSL certificate verifications for others than Let's Encrypt #31856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do no longer (wrongly) rewrite URLs like - http://example.net/.well-known/pki-validation/file.txt (Comodo) - http://example.net/.well-known/pki-validation/fileauth.txt (DigiCert, Thawte, GeoTrust) - http://example.net/.well-known/pki-validation/gsdv.txt (GlobalSign) - http://example.net/.well-known/pki-validation/starfield.htm (Starfield, GoDaddy) - http://example.net/.well-known/pki-validation/swisssign-check.txt (SwissSign) for automated SSL certificate verifications. All (common commercial) certificate authorities (CA) except Let's Encrypt (via ACME) seem to use "pki-validation" rather "acme-challenge" for their domain control validation (DCV). Note that this is required inside of ownCloud rather on web server level due to shared web hosting systems, where the customer/user might not be able to do this on web server level (Apache/Nginx configuration changes for the virtual host). Signed-off-by: Robert Scheck <robert@fedoraproject.org>
|
|
DeepDiver1975
approved these changes
Jun 21, 2018
Codecov Report
@@ Coverage Diff @@
## master #31856 +/- ##
============================================
- Coverage 63.27% 63.23% -0.05%
- Complexity 18476 18488 +12
============================================
Files 1161 1161
Lines 69371 69486 +115
Branches 1261 1261
============================================
+ Hits 43895 43936 +41
- Misses 25106 25180 +74
Partials 370 370
Continue to review full report at Codecov.
|
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do no longer (wrongly) rewrite URLs like
for automated SSL certificate verifications. All (common commercial) certificate authorities (CA) except Let's Encrypt (via ACME) seem to use "pki-validation" rather "acme-challenge" for their domain control validation (DCV). Note that this is required inside of ownCloud rather on web server level due to shared web hosting systems, where the customer/user might not be able to do this on web server level (Apache/Nginx configuration changes for the virtual host).
As per https://owncloud.org/community/develop/contributor-agreement/ I am releasing my code/contribution (this PR) under the MIT license.