Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search API to capabilities #31943

Merged
merged 2 commits into from
Jul 4, 2018
Merged

Add search API to capabilities #31943

merged 2 commits into from
Jul 4, 2018

Conversation

jvillafanez
Copy link
Member

Description

Add the search API to the server capabilities

Related Issue

#25373

Motivation and Context

How Has This Been Tested?

Manually tested

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jvillafanez jvillafanez added this to the development milestone Jun 28, 2018
@jvillafanez jvillafanez self-assigned this Jun 28, 2018
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 great

@codecov
Copy link

codecov bot commented Jun 28, 2018

Codecov Report

Merging #31943 into master will increase coverage by <.01%.
The diff coverage is 62.5%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #31943      +/-   ##
============================================
+ Coverage     63.46%   63.46%   +<.01%     
- Complexity    18524    18526       +2     
============================================
  Files          1167     1167              
  Lines         69479    69481       +2     
  Branches       1264     1264              
============================================
+ Hits          44096    44099       +3     
+ Misses        25014    25013       -1     
  Partials        369      369
Flag Coverage Δ Complexity Δ
#javascript 52.58% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 64.71% <62.5%> (ø) 18526 <1> (+2) ⬆️
Impacted Files Coverage Δ Complexity Δ
apps/dav/lib/Capabilities.php 0% <0%> (ø) 1 <0> (ø) ⬇️
...av/lib/Connector/Sabre/FilesSearchReportPlugin.php 96.92% <100%> (+0.14%) 15 <1> (+2) ⬆️
apps/files_sharing/lib/Notifier.php 100% <0%> (ø) 19% <0%> (ø) ⬇️
apps/federatedfilesharing/lib/Notifier.php 0% <0%> (ø) 11% <0%> (ø) ⬇️
...uthentication/Exceptions/AccountCheckException.php 100% <0%> (ø) 2% <0%> (ø) ⬇️
lib/private/User/Session.php 78.22% <0%> (+0.1%) 150% <0%> (ø) ⬇️
.../files_sharing/lib/Controllers/ShareController.php 53.52% <0%> (+0.21%) 54% <0%> (ø) ⬇️
apps/federatedfilesharing/appinfo/app.php 20.83% <0%> (+0.83%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4664e17...811f479. Read the comment docs.

@jvillafanez jvillafanez mentioned this pull request Jun 29, 2018
9 tasks
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit 10abccf into master Jul 4, 2018
@PVince81 PVince81 deleted the search_api_capability branch July 4, 2018 11:01
@PVince81
Copy link
Contributor

PVince81 commented Jul 4, 2018

@jvillafanez please backport or cherry-pick on the stable10 backport of the search API

@jvillafanez
Copy link
Member Author

#31946 already contains these commits.

@phil-davis
Copy link
Contributor

Backport PR #31946 has been merged.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants