Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize acceptance test skip tags #32351

Merged
merged 1 commit into from
Aug 16, 2018
Merged

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Aug 16, 2018

Description

Make all skip tags have the same format for specifying the issue.

Motivation and Context

Some acceptance test skip tags were in different formats, making them harder to find.
We specify the issue number in format issue-12345 for core and app_name-issue-123 for an issue that was raised in an app.

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@phil-davis
Copy link
Contributor Author

Backport stable10 #32352

@codecov
Copy link

codecov bot commented Aug 16, 2018

Codecov Report

Merging #32351 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #32351   +/-   ##
=========================================
  Coverage     64.01%   64.01%           
  Complexity    18564    18564           
=========================================
  Files          1171     1171           
  Lines         69851    69851           
  Branches       1267     1267           
=========================================
  Hits          44714    44714           
  Misses        24767    24767           
  Partials        370      370
Flag Coverage Δ Complexity Δ
#javascript 52.84% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.28% <ø> (ø) 18564 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1e220e...c3558dd. Read the comment docs.

@phil-davis phil-davis merged commit d3f0cea into master Aug 16, 2018
@phil-davis phil-davis deleted the standardize-skip-tags branch August 16, 2018 08:52
@lock lock bot locked as resolved and limited conversation to collaborators Aug 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants