Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API acceptance tests for case-sensitive file move-rename #32358

Merged
merged 2 commits into from
Aug 16, 2018

Conversation

phil-davis
Copy link
Contributor

Description

  1. Make the content of the apiSkeleton text files all a bit different, so we can easily test which file is "really" which.
  2. Add test scenarios for moving files with case differences.

Related Issue

#32357 part

Motivation and Context

Test.allTheThings

How Has This Been Tested?

Local test runs

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@individual-it
Copy link
Member

backport in #32359

@phil-davis
Copy link
Contributor Author

I added a total of 23 bytes to the skeleton files. I will push a commit that reduces the expected quota by 23 bytes in the relevant tests.

@codecov
Copy link

codecov bot commented Aug 16, 2018

Codecov Report

Merging #32358 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #32358   +/-   ##
=========================================
  Coverage     64.01%   64.01%           
  Complexity    18564    18564           
=========================================
  Files          1171     1171           
  Lines         69851    69851           
  Branches       1267     1267           
=========================================
  Hits          44714    44714           
  Misses        24767    24767           
  Partials        370      370
Flag Coverage Δ Complexity Δ
#javascript 52.84% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.28% <ø> (ø) 18564 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ed910d...3e2b879. Read the comment docs.

@phil-davis phil-davis merged commit e53ccba into master Aug 16, 2018
@phil-davis phil-davis deleted the case-sensitive-move-tests branch August 16, 2018 10:24
@lock lock bot locked as resolved and limited conversation to collaborators Aug 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants