Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split api acceptance suites #32369

Merged
merged 3 commits into from
Aug 17, 2018
Merged

Split api acceptance suites #32369

merged 3 commits into from
Aug 17, 2018

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Aug 17, 2018

Description

  1. Split apiWebdav suite into apiWebdavOperations (upload, download, delete... files and folders) and apiWebdavProperties (copy, move, rename, set and get other properties)
  2. Split apiSharing suite into apiShareManagement (creating, setting permissions, deleting shares) and apiShareOperations (upload, download, delete... files and folders in shares)
  3. Add apiMetadataApps suite - these are currently comments, favorites and tags - which add metadata about files/folders.

Motivation and Context

Some API acceptance test suites are taking quite a long time to run, even on drone - about 30 minutes.

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Acceptance tests added

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@phil-davis
Copy link
Contributor Author

Backport stable10 #32370

@codecov
Copy link

codecov bot commented Aug 17, 2018

Codecov Report

Merging #32369 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #32369   +/-   ##
=========================================
  Coverage     64.03%   64.03%           
  Complexity    18579    18579           
=========================================
  Files          1171     1171           
  Lines         69876    69876           
  Branches       1267     1267           
=========================================
  Hits          44747    44747           
  Misses        24759    24759           
  Partials        370      370
Flag Coverage Δ Complexity Δ
#javascript 52.84% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.31% <ø> (ø) 18579 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5936799...00247ef. Read the comment docs.

@phil-davis phil-davis merged commit 4afa58b into master Aug 17, 2018
@phil-davis phil-davis deleted the split-api-acceptance-suites branch August 17, 2018 09:59
@lock lock bot locked as resolved and limited conversation to collaborators Aug 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants