Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] Use createPositionalParameter() - see https://github.com/o… #32412

Merged
merged 1 commit into from
Aug 22, 2018
Merged

[stable10] Use createPositionalParameter() - see https://github.com/o… #32412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/files_sharing/lib/Command/CleanupRemoteStorages.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,13 +138,13 @@ public function getRemoteStorages() {
->where($queryBuilder->expr()->like(
'id',
// match all 'shared::' + 32 characters storages
$queryBuilder->createNamedParameter('shared::________________________________', IQueryBuilder::PARAM_STR),
$queryBuilder->createPositionalParameter('shared::________________________________', IQueryBuilder::PARAM_STR),
IQueryBuilder::PARAM_STR)
)
->andWhere($queryBuilder->expr()->notLike(
'id',
// but not the ones starting with a '/', they are for normal shares
$queryBuilder->createNamedParameter('shared::/%', IQueryBuilder::PARAM_STR),
$queryBuilder->createPositionalParameter('shared::/%', IQueryBuilder::PARAM_STR),
IQueryBuilder::PARAM_STR)
)->orderBy('numeric_id');
$query = $queryBuilder->execute();
Expand Down
8 changes: 4 additions & 4 deletions lib/private/Files/Type/Loader.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,15 +161,15 @@ public function updateFilecache($ext, $mimetypeId) {
$is_folderId = $this->getId('httpd/unix-directory');
$update = $this->dbConnection->getQueryBuilder();
$update->update('filecache')
->set('mimetype', $update->createNamedParameter($mimetypeId))
->set('mimetype', $update->createPositionalParameter($mimetypeId))
->where($update->expr()->neq(
'mimetype', $update->createNamedParameter($mimetypeId)
'mimetype', $update->createPositionalParameter($mimetypeId)
))
->andwhere($update->expr()->neq(
'mimetype', $update->createNamedParameter($is_folderId)
'mimetype', $update->createPositionalParameter($is_folderId)
))
->andWhere($update->expr()->like(
$update->createFunction('LOWER(`name`)'), $update->createNamedParameter($ext)
$update->createFunction('LOWER(`name`)'), $update->createPositionalParameter($ext)
));
return $update->execute();
}
Expand Down
4 changes: 2 additions & 2 deletions lib/private/SystemTag/SystemTagManager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,14 +133,14 @@ public function getAllTags($visibilityFilter = null, $nameSearchPattern = null)
->from(self::TAG_TABLE);

if ($visibilityFilter !== null) {
$query->andWhere($query->expr()->eq('visibility', $query->createNamedParameter((int)$visibilityFilter)));
$query->andWhere($query->expr()->eq('visibility', $query->createPositionalParameter((int)$visibilityFilter)));
}

if (!empty($nameSearchPattern)) {
$query->andWhere(
$query->expr()->like(
'name',
$query->createNamedParameter('%' . $this->connection->escapeLikeParameter($nameSearchPattern). '%')
$query->createPositionalParameter('%' . $this->connection->escapeLikeParameter($nameSearchPattern). '%')
)
);
}
Expand Down
8 changes: 4 additions & 4 deletions lib/private/User/AccountMapper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,10 +168,10 @@ public function find($pattern, $limit = null, $offset = null) {
->from($this->getTableName(), 'a')
->leftJoin('a', 'account_terms', 't', $qb->expr()->eq('a.id', 't.account_id'))
->orderBy('display_name')
->where($qb->expr()->like('lower_user_id', $qb->createNamedParameter($loweredParameter)))
->orWhere($qb->expr()->iLike('display_name', $qb->createNamedParameter($parameter)))
->orWhere($qb->expr()->iLike('email', $qb->createNamedParameter($parameter)))
->orWhere($qb->expr()->like('t.term', $qb->createNamedParameter($loweredParameter)));
->where($qb->expr()->like('lower_user_id', $qb->createPositionalParameter($loweredParameter)))
->orWhere($qb->expr()->iLike('display_name', $qb->createPositionalParameter($parameter)))
->orWhere($qb->expr()->iLike('email', $qb->createPositionalParameter($parameter)))
->orWhere($qb->expr()->like('t.term', $qb->createPositionalParameter($loweredParameter)));

return $this->findEntities($qb->getSQL(), $qb->getParameters(), $limit, $offset);
}
Expand Down