Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skipOnLDAP test scenarios that add a user to a group #32441

Merged
merged 1 commit into from
Aug 26, 2018

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Aug 26, 2018

Description

skipOnLDAP the new acceptance test scenarios added by PR #31913

Related Issue

#31870

Motivation and Context

These acceptance test scenarios are failing on user_ldap CI because they need to change group membership during the test - they try to add user3 t ogrp1. In the LDAP environment, that cannot be done within ownCloud. So we need to skip such scenarios.

Some time in the future we might add the capability for the acceptance tests to "externally" manage the test LDAP server and sync changes etc, but not now.

How Has This Been Tested?

We will know when user_ldap CI runs overnight.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@phil-davis
Copy link
Contributor Author

Backport stable10 #32442

@codecov
Copy link

codecov bot commented Aug 26, 2018

Codecov Report

Merging #32441 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #32441   +/-   ##
=========================================
  Coverage     64.06%   64.06%           
  Complexity    18634    18634           
=========================================
  Files          1176     1176           
  Lines         70142    70142           
  Branches       1267     1267           
=========================================
  Hits          44934    44934           
  Misses        24838    24838           
  Partials        370      370
Flag Coverage Δ Complexity Δ
#javascript 52.84% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.33% <ø> (ø) 18634 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e995a64...f565256. Read the comment docs.

@individual-it individual-it merged commit 4b67bd9 into master Aug 26, 2018
@phil-davis phil-davis deleted the SharingNotifications-skipOnLDAP branch August 26, 2018 09:19
@lock lock bot locked as resolved and limited conversation to collaborators Aug 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants