Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Include new config sample for apps in dist build #32635

Merged
merged 1 commit into from
Sep 7, 2018

Conversation

PVince81
Copy link
Contributor

@PVince81 PVince81 commented Sep 7, 2018

Port of #32634 to master

Include config/config.apps.sample.php in dist and dist-qa builds.
Copy link
Contributor

@mmattel mmattel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 👍

@codecov
Copy link

codecov bot commented Sep 7, 2018

Codecov Report

Merging #32635 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #32635   +/-   ##
=========================================
  Coverage     64.14%   64.14%           
  Complexity    18681    18681           
=========================================
  Files          1177     1177           
  Lines         70283    70283           
  Branches       1270     1270           
=========================================
  Hits          45085    45085           
  Misses        24828    24828           
  Partials        370      370
Flag Coverage Δ Complexity Δ
#javascript 52.89% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.42% <ø> (ø) 18681 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2551ab...673682a. Read the comment docs.

@PVince81 PVince81 merged commit 8f22c52 into master Sep 7, 2018
@PVince81 PVince81 deleted the master-makefile-config-apps-sample branch September 7, 2018 10:31
@lock lock bot locked as resolved and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants