Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable10] fix then steps update share #33331

Merged
merged 1 commit into from
Oct 29, 2018
Merged

[stable10] fix then steps update share #33331

merged 1 commit into from
Oct 29, 2018

Conversation

paurakhsharma
Copy link
Member

Backport of: #33329

@paurakhsharma paurakhsharma added this to the development milestone Oct 29, 2018
@paurakhsharma paurakhsharma self-assigned this Oct 29, 2018
@paurakhsharma paurakhsharma mentioned this pull request Oct 29, 2018
Merged
10 tasks
@codecov
Copy link

codecov bot commented Oct 29, 2018 •
edited
Loading

Codecov Report

Merging #33331 into stable10 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable10   #33331   +/-   ##
===========================================
  Coverage       62.91%   62.91%           
  Complexity      18867    18867           
===========================================
  Files            1237     1237           
  Lines           73960    73960           
  Branches         1282     1282           
===========================================
  Hits            46529    46529           
  Misses          27051    27051           
  Partials          380      380
Flag Coverage Δ Complexity Δ
#javascript 53.16% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 63.96% <ø> (ø) 18867 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8478235...329c2ac. Read the comment docs.

@phil-davis phil-davis merged commit 399416f into stable10 Oct 29, 2018
@phil-davis phil-davis deleted the stable10-fix-then-steps-updateShare branch October 29, 2018 09:43
@ownclouders ownclouders mentioned this pull request Jan 4, 2019
Closed
@PVince81 PVince81 modified the milestones: development, QA Jan 11, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jan 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@individual-it individual-it Awaiting requested review from individual-it

Assignees

@paurakhsharma paurakhsharma

Labels
4 - To release dev:acceptance-tests QA:team
Projects
None yet
Milestone
10.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@paurakhsharma @phil-davis @PVince81