Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration for bigint on DAV tables #33545

Merged
merged 1 commit into from
Nov 19, 2018
Merged

Conversation

PVince81
Copy link
Contributor

Description

Convert id columns of many DAV-related tables to bigint.

Note that some of these migrations might have existed before
but some update paths did not trigger them properly, so this
migration here exists to align all update paths.

Related Issue

Fixes #32555

Motivation and Context

How Has This Been Tested?

Setup OC from scratch and check that every id column of the affected tables now appears as BIGINT on MariaDB.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

Convert id columns of many DAV-related tables to bigint.

Note that some of these migrations might have existed before
but some update paths did not trigger them properly, so this
migration here exists to align all update paths.
@codecov
Copy link

codecov bot commented Nov 16, 2018

Codecov Report

Merging #33545 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #33545      +/-   ##
============================================
- Coverage     64.12%    64.1%   -0.02%     
- Complexity    18305    18308       +3     
============================================
  Files          1193     1194       +1     
  Lines         69155    69175      +20     
  Branches       1277     1277              
============================================
  Hits          44343    44343              
- Misses        24440    24460      +20     
  Partials        372      372
Flag Coverage Δ Complexity Δ
#javascript 52.91% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.4% <0%> (-0.03%) 18308 <3> (+3)
Impacted Files Coverage Δ Complexity Δ
...s/dav/appinfo/Migrations/Version20181115210344.php 0% <0%> (ø) 3 <3> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8565399...aed3a2b. Read the comment docs.

@DeepDiver1975 DeepDiver1975 merged commit e607745 into master Nov 19, 2018
@DeepDiver1975 DeepDiver1975 deleted the missing-bigint-migrations branch November 19, 2018 07:08
@DeepDiver1975
Copy link
Member

Backport the next days to see if this all works properly in upgrade testing ....

@PVince81
Copy link
Contributor Author

stable10: #33603

@lock lock bot locked as resolved and limited conversation to collaborators Dec 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Columns that used to be bigint are int in some setup scenarios
2 participants