deleting a file when 2 files exist with different case

[davitol]

Related Issue

#32357 part

Motivation and Context

Spread Tests

How Has This Been Tested?

Local test runs

[codecov]

Codecov Report

Merging #33597 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #33597      +/-   ##
============================================
+ Coverage     64.22%   64.22%   +<.01%     
+ Complexity    18431    18269     -162     
============================================
  Files          1193     1193              
  Lines         69076    69077       +1     
  Branches       1277     1277              
============================================
+ Hits          44363    44364       +1     
  Misses        24341    24341              
  Partials        372      372

Flag	Coverage Δ	Complexity Δ
#javascript	52.91% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	65.53% <ø> (ø)	18269 <ø> (-162)	⬇️

Impacted Files	Coverage Δ	Complexity Δ
apps/files/lib/Command/VerifyChecksums.php	96.42% <0%> (+0.04%)	37% <0%> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 266c5e6...3e4da84. Read the comment docs.

[phil-davis]

This scenario fails for me locally. I don't know how it passed CI on drone - maybe related to the recent drone problems???

I suggest that each file should have different content. Then delete one of the files. Check that the deleted file does not exist, check that the remaining file has the expected content. That will confirm that both the correct file name and the correct file content were deleted.

code has been adjusted

[phil-davis]

I looked at the current drone logs and the new scenario is being run, and it passes.
https://drone.owncloud.com/owncloud/core/12889/406

  Scenario Outline: delete a file when 2 files exist with different case                   # /drone/src/tests/acceptance/features/apiWebdavOperations/deleteFile.feature:22
    Given using <dav_version> DAV path                                                     # FeatureContext::usingOldOrNewDavPath()
    And user "user0" has uploaded file with content "to delete" to "/textfile1.txt"        # FeatureContext::userUploadsAFileWithContentTo()
    And user "user0" has uploaded file with content "uploaded content" to "/TextFile1.txt" # FeatureContext::userUploadsAFileWithContentTo()
    When user "user0" deletes file "/textfile1.txt" using the WebDAV API                   # FeatureContext::userDeletesFile()
    Then the HTTP status code should be "204"                                              # FeatureContext::theHTTPStatusCodeShouldBe()
    And as "user0" file "/textfile1.txt" should not exist                                  # FeatureContext::asFileOrFolderShouldNotExist()
    And as "user0" file "/TextFile1.txt" should exist                                      # FeatureContext::asFileOrFolderShouldExist()
    And the content of file "/TextFile1.txt" for user "user0" should be "uploaded content" # FeatureContext::contentOfFileForUserShouldBe()

    Examples:
      | dav_version |
      | old         |
| new         |

So at least we now know that CI runs the new scenario.

[phil-davis]

@davitol when making the backport, please make sure that you have pulled the very latest stable10 of core, and branch from that. Maybe the problems we have been having are related to PRs branched from old master or stable10 - I don't know.

[davitol]

Backport in : #33633