Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in checksum verify command #33612

Merged
merged 2 commits into from
Nov 21, 2018
Merged

Fix bugs in checksum verify command #33612

merged 2 commits into from
Nov 21, 2018

Conversation

IljaN
Copy link
Contributor

@IljaN IljaN commented Nov 21, 2018

Forward port of #33610

@IljaN IljaN added this to the development milestone Nov 21, 2018
@IljaN IljaN self-assigned this Nov 21, 2018
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Issue #33051 and sub-issue #33613 are pending for creating acceptance tests for this sort of stuff.

@codecov
Copy link

codecov bot commented Nov 21, 2018

Codecov Report

Merging #33612 into master will increase coverage by <.01%.
The diff coverage is 85.71%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #33612      +/-   ##
============================================
+ Coverage     64.22%   64.22%   +<.01%     
+ Complexity    18431    18269     -162     
============================================
  Files          1193     1193              
  Lines         69076    69077       +1     
  Branches       1277     1277              
============================================
+ Hits          44363    44364       +1     
  Misses        24341    24341              
  Partials        372      372
Flag Coverage Δ Complexity Δ
#javascript 52.91% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.53% <85.71%> (ø) 18269 <0> (-162) ⬇️
Impacted Files Coverage Δ Complexity Δ
apps/files/lib/Command/VerifyChecksums.php 96.42% <85.71%> (+0.04%) 37 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 266c5e6...29d2362. Read the comment docs.

@IljaN IljaN merged commit 42a9038 into master Nov 21, 2018
@IljaN IljaN deleted the checksum_verify_bug_master branch November 21, 2018 15:45
@lock lock bot locked as resolved and limited conversation to collaborators Nov 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants