Duplicate DB entries in filecache table when renaming folder in WebUI #2 #3388
Conversation
|
Doesn't look like Jenkins failed specifically because of your commits. @DeepDiver1975 Can you investigate? Looks good now @roha4000 and thanks for the tests. Could you take a look at http://owncloud.org/about/contributor-agreement/ |
aaargh - yes phpunit is seg faulting |
|
I've just send the signed agreement to Frank. |
|
got it. Ready for merge if reviewed. |
|
@owncloud-bot retest this please |
|
Seems that phpunit is still segfaulting. |
yeah - related to some issue within the clover report generation |
|
Well, I'm not sure how to proceed. Can I just merge the pr or shall I wait for the test to be restartet and / or a review? |
|
@roha4000 our review process requires two people giving a +1 before you can merge any pr. Maybe I'll have a look tonight. @icewind1991 can you have a look as well |
|
@roha4000 rebase please |
|
Something went wrong with that rebase. What did you do? |
… move(). Add storage id to the where clause to avoid updating entries of other users.
…ntries Added a second storage and cache Object to simulate a second user.
|
Yeah, something went wrong :-). I've tried to get rid of the Merge Commit after rebasing to the upstream ... anyway it should be OK now. |
|
I rebased as requested. Could someone invest some time to review this two lines of changed code and the adapted unit test please? |
|
👍 Looks good |
|
Now we're good 👍 |
Duplicate DB entries in filecache table when renaming folder in WebUI #2
|
Backport: 07fb230 |
I previously sent a Pull Request concerning this Bug but screwed up the commit because I just copied the changes I made on the 5.0.5 TAG to the trunk. Well, that did not work out.
Now this one passes the unit tests. I also added some additional tests to ensure that another users cache entries are not Updated. Hope this one will do it :-)
To reproduce the Bug you need two users having the same folder structure. The folders must contain at least one file. Now rename one folder and all filecache entries with the same path will be updated with the new folder name ... regardless of the storage id.