Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small config sample fixes #33953

Merged
merged 1 commit into from
Dec 20, 2018
Merged

Small config sample fixes #33953

merged 1 commit into from
Dec 20, 2018

Conversation

mmattel
Copy link
Contributor

@mmattel mmattel commented Dec 20, 2018

Description

Small config sample fixes, no content change.

Related Issue

No Issue related, just found and fixed

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@mmattel
Copy link
Contributor Author

mmattel commented Dec 20, 2018

drone: webui-acceptance-tests are failing ??

@mmattel
Copy link
Contributor Author

mmattel commented Dec 20, 2018

@ownclouders rebase

@ownclouders
Copy link
Contributor

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

@ownclouders
Copy link
Contributor

Automated rebase with GitMate.io was successful! 🎉

@phil-davis
Copy link
Contributor

Weird drone fail https://drone.owncloud.com/owncloud/core/13759/720
I restarted the drone build

@phil-davis
Copy link
Contributor

@ownclouders rebase

@ownclouders
Copy link
Contributor

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

@ownclouders ownclouders force-pushed the small_config_sample_fix branch from e9231ba to 9a1e20b Compare December 20, 2018 17:34
@ownclouders
Copy link
Contributor

Automated rebase with GitMate.io was successful! 🎉

@codecov
Copy link

codecov bot commented Dec 20, 2018

Codecov Report

Merging #33953 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #33953      +/-   ##
============================================
+ Coverage     64.76%   64.77%   +0.01%     
- Complexity    18336    18337       +1     
============================================
  Files          1198     1198              
  Lines         69403    69422      +19     
  Branches       1276     1276              
============================================
+ Hits          44950    44970      +20     
+ Misses        24084    24083       -1     
  Partials        369      369
Flag Coverage Δ Complexity Δ
#javascript 53.09% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.12% <ø> (+0.01%) 18337 <ø> (+1) ⬆️
Impacted Files Coverage Δ Complexity Δ
config/config.apps.sample.php 0% <ø> (ø) 0 <0> (ø) ⬇️
apps/files_sharing/lib/Capabilities.php 100% <0%> (+1.75%) 10% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad225a4...9a1e20b. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 20, 2018

Codecov Report

Merging #33953 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #33953   +/-   ##
=========================================
  Coverage     64.76%   64.76%           
  Complexity    18336    18336           
=========================================
  Files          1198     1198           
  Lines         69403    69403           
  Branches       1276     1276           
=========================================
  Hits          44950    44950           
  Misses        24084    24084           
  Partials        369      369
Flag Coverage Δ Complexity Δ
#javascript 53.09% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.11% <ø> (ø) 18336 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
config/config.apps.sample.php 0% <ø> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad225a4...9a1e20b. Read the comment docs.

@phil-davis phil-davis merged commit 4454737 into master Dec 20, 2018
@delete-merged-branch delete-merged-branch bot deleted the small_config_sample_fix branch December 20, 2018 18:13
* config option
* * use RST syntax
* If you have multiple possible values in the comment section, seperate them with a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TYPO in seperate, JFYI. Seen while testing 10.1 beta Changelog

Copy link
Contributor Author

@mmattel mmattel Jan 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls see fix in #34019 , backport in #34020

@davitol davitol mentioned this pull request Jan 3, 2019
39 tasks
@lock lock bot locked as resolved and limited conversation to collaborators Jan 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants