Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Run webUISharingExternal suite 20 times to see how often it fails (short) #34189

Closed

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Jan 21, 2019

and shorten the webUISharingExternal suite to see if the scenarios fail when run by themselves.

Issue #34186

@phil-davis phil-davis self-assigned this Jan 21, 2019
@codecov
Copy link

codecov bot commented Jan 21, 2019

Codecov Report

Merging #34189 into master will decrease coverage by 11.66%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #34189       +/-   ##
=============================================
- Coverage     64.76%   53.09%   -11.67%     
=============================================
  Files          1198       61     -1137     
  Lines         69467     7217    -62250     
  Branches       1281     1281               
=============================================
- Hits          44989     3832    -41157     
+ Misses        24105     3012    -21093     
  Partials        373      373
Flag Coverage Δ Complexity Δ
#javascript 53.09% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit ? ?
Impacted Files Coverage Δ Complexity Δ
apps/updatenotification/templates/admin.php
lib/private/Encryption/Keys/Storage.php
lib/private/App/CodeChecker/NodeVisitor.php
lib/private/RedisFactory.php
apps/dav/lib/Avatars/AvatarNode.php
...s/dav/appinfo/Migrations/Version20170202213905.php
apps/dav/lib/Upload/ChunkLocationProvider.php
apps/files/lib/AppInfo/Application.php
apps/systemtags/list.php
apps/files_external/lib/Lib/Backend/DAV.php
... and 1127 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3515439...8c45be3. Read the comment docs.

@codecov
Copy link

codecov bot commented Jan 21, 2019

Codecov Report

Merging #34189 into master will decrease coverage by 11.66%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #34189       +/-   ##
=============================================
- Coverage     64.76%   53.09%   -11.67%     
=============================================
  Files          1198       61     -1137     
  Lines         69467     7217    -62250     
  Branches       1281     1281               
=============================================
- Hits          44989     3832    -41157     
+ Misses        24105     3012    -21093     
  Partials        373      373
Flag Coverage Δ Complexity Δ
#javascript 53.09% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit ? ?
Impacted Files Coverage Δ Complexity Δ
apps/updatenotification/templates/admin.php
lib/private/Encryption/Keys/Storage.php
lib/private/App/CodeChecker/NodeVisitor.php
lib/private/RedisFactory.php
apps/dav/lib/Avatars/AvatarNode.php
...s/dav/appinfo/Migrations/Version20170202213905.php
apps/dav/lib/Upload/ChunkLocationProvider.php
apps/files/lib/AppInfo/Application.php
apps/systemtags/list.php
apps/files_external/lib/Lib/Backend/DAV.php
... and 1127 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3515439...1bd9851. Read the comment docs.

@phil-davis
Copy link
Contributor Author

The tests pass 100 times! I cannot reproduce the fails that happened on some PRs last week.

@phil-davis phil-davis closed this Jan 21, 2019
@phil-davis phil-davis deleted the webUISharingExternal-testing-20190121-short branch January 21, 2019 04:44
@lock lock bot locked as resolved and limited conversation to collaborators Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant