Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump phpseclib/phpseclib (2.0.13 => 2.0.14) #34265

Closed
wants to merge 1 commit into from

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Jan 28, 2019

Description

composer update
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 0 installs, 2 updates, 0 removals
  - Updating phpseclib/phpseclib (2.0.13 => 2.0.14): Downloading (100%)

https://github.com/phpseclib/phpseclib/releases/tag/2.0.14

Motivation and Context

Keep up-to-date

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@phil-davis
Copy link
Contributor Author

Backport stable10 #34266

@codecov
Copy link

codecov bot commented Jan 28, 2019

Codecov Report

Merging #34265 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #34265   +/-   ##
=========================================
  Coverage     64.76%   64.76%           
  Complexity    18363    18363           
=========================================
  Files          1198     1198           
  Lines         69538    69538           
  Branches       1281     1281           
=========================================
  Hits          45035    45035           
  Misses        24130    24130           
  Partials        373      373
Flag Coverage Δ Complexity Δ
#javascript 53.09% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.11% <ø> (ø) 18363 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55c4b78...eba3645. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jan 28, 2019

Codecov Report

Merging #34265 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #34265   +/-   ##
=========================================
  Coverage     64.76%   64.76%           
  Complexity    18363    18363           
=========================================
  Files          1198     1198           
  Lines         69538    69538           
  Branches       1281     1281           
=========================================
  Hits          45035    45035           
  Misses        24130    24130           
  Partials        373      373
Flag Coverage Δ Complexity Δ
#javascript 53.09% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.11% <ø> (ø) 18363 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55c4b78...eba3645. Read the comment docs.

@PVince81
Copy link
Contributor

seems we don't have automated tests with SFTP + docker any more ? I think we had with Travis but am not sure. this will then need manual testing with SFTP external storage.

cc @davitol

@phil-davis
Copy link
Contributor Author

The bot found it - see #34284

@phil-davis phil-davis closed this Jan 29, 2019
@phil-davis phil-davis deleted the bump-phpseclib-2.0.14 branch January 29, 2019 02:14
@lock lock bot locked as resolved and limited conversation to collaborators Jan 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants