Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check lock timeout #34320

Merged
merged 1 commit into from
Jan 30, 2019
Merged

check lock timeout #34320

merged 1 commit into from
Jan 30, 2019

Conversation

individual-it
Copy link
Member

@individual-it individual-it commented Jan 30, 2019

Description

test to set and get lock timeouts

Related Issue

Motivation and Context

fill the blanks #34292

How Has This Been Tested?

🤖

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@codecov
Copy link

codecov bot commented Jan 30, 2019

Codecov Report

Merging #34320 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #34320   +/-   ##
=========================================
  Coverage     64.76%   64.76%           
  Complexity    18368    18368           
=========================================
  Files          1199     1199           
  Lines         69550    69550           
  Branches       1281     1281           
=========================================
  Hits          45044    45044           
  Misses        24133    24133           
  Partials        373      373
Flag Coverage Δ Complexity Δ
#javascript 53.09% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.11% <ø> (ø) 18368 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d1427b...11dcf94. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jan 30, 2019

Codecov Report

Merging #34320 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #34320   +/-   ##
=========================================
  Coverage     64.76%   64.76%           
  Complexity    18368    18368           
=========================================
  Files          1199     1199           
  Lines         69550    69550           
  Branches       1281     1281           
=========================================
  Hits          45044    45044           
  Misses        24133    24133           
  Partials        373      373
Flag Coverage Δ Complexity Δ
#javascript 53.09% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.11% <ø> (ø) 18368 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d1427b...11dcf94. Read the comment docs.

@phil-davis phil-davis merged commit d7b743c into master Jan 30, 2019
@delete-merged-branch delete-merged-branch bot deleted the checkLockTimeout branch January 30, 2019 10:04
@individual-it
Copy link
Member Author

backport in #34323

@lock lock bot locked as resolved and limited conversation to collaborators Feb 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

acceptance tests for timeout section in LOCKDISCOVERY
2 participants