Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split slow acceptance test suites #34330

Merged
merged 8 commits into from
Jan 31, 2019

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Jan 30, 2019

Description

  1. Add acceptance test suites and move appropriate features into them:
apiVersions
apiWebdavMove
apiWebdavUpload
webUICreateDelete
webUISharingAcceptShares
webUISharingPublic
webUIWebdavLockProtection
  1. Split webUIWebdavLocks locks.feature into more feature files
  2. Reformat feature files to indent standard (mostly my IDE reformatted gherkin tables to line up nicely)

Related Issue

#34264

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@codecov
Copy link

codecov bot commented Jan 30, 2019

Codecov Report

Merging #34330 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #34330   +/-   ##
=========================================
  Coverage     64.76%   64.76%           
  Complexity    18368    18368           
=========================================
  Files          1199     1199           
  Lines         69550    69550           
  Branches       1281     1281           
=========================================
  Hits          45044    45044           
  Misses        24133    24133           
  Partials        373      373
Flag Coverage Δ Complexity Δ
#javascript 53.09% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.11% <ø> (ø) 18368 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb2194a...8204584. Read the comment docs.

@codecov
Copy link

codecov bot commented Jan 30, 2019

Codecov Report

Merging #34330 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #34330   +/-   ##
=========================================
  Coverage     64.76%   64.76%           
  Complexity    18368    18368           
=========================================
  Files          1199     1199           
  Lines         69550    69550           
  Branches       1281     1281           
=========================================
  Hits          45044    45044           
  Misses        24133    24133           
  Partials        373      373
Flag Coverage Δ Complexity Δ
#javascript 53.09% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.11% <ø> (ø) 18368 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68c4b20...14683a6. Read the comment docs.

@phil-davis phil-davis force-pushed the split-slow-accceptance-test-suites-20190130 branch from 8204584 to f5aaff3 Compare January 30, 2019 14:34
@phil-davis
Copy link
Contributor Author

Backport stable10 #34332

@lock lock bot locked as resolved and limited conversation to collaborators Jan 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants